chrome/browser/ui/webui/engagement/site_engagement.mojom - Issue 1316043003: Add chrome://site-engagement WebUI.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/ui/webui/engagement/site_engagement.mojom

Issue 1316043003: Add chrome://site-engagement WebUI. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@navigation_smarter

Patch Set: fix build more Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 // Copyright 2015 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 struct SiteEngagementInfo {

	6 string origin;

	7 int32 score;

	8 };

	9

	10 interface SiteEngagementUIHandlerMojo {

	11 GetSiteEngagementInfo(SiteEngagementPage page);

	12 };

	13

	14 interface SiteEngagementPage {

	15 HandleSiteEngagementInfo(array<SiteEngagementInfo> info);
	Sam McNally 2015/08/26 08:23:22 Is this called more than once? If not, you can ma Is this called more than once? If not, you can make \|info\| a return value for GetSiteEngagementInfo: GetSiteEngagementInfo() => (array<SiteEngagementInfo> info); The JS binding for that pattern is a function that returns a promise to a dictionary containing an \|info\| field (mojo supports multiple return values, unlike JS promises). calamity 2015/09/08 07:30:06 It most likely will be at some point. We would wan Show quoted text On 2015/08/26 08:23:22, Sam McNally wrote: > Is this called more than once? > > If not, you can make \|info\| a return value for GetSiteEngagementInfo: > GetSiteEngagementInfo() => (array<SiteEngagementInfo> info); > > The JS binding for that pattern is a function that returns a promise to a > dictionary containing an \|info\| field (mojo supports multiple return values, > unlike JS promises). It most likely will be at some point. We would want the page to update when someone presses a button, for example.
	16 };

OLD	NEW