Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(709)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1316013007: Added a test for pointercancel from touchcancel. (Closed)

Created:
5 years, 3 months ago by mustaq
Modified:
5 years, 3 months ago
Reviewers:
Rick Byers
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Added a test for pointercancel from touchcancel. This went untested before, but our pointercancel firing code for touch scroll already takes care of it. BUG=476576 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201924

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+56 lines, -2 lines) Patch
M LayoutTests/fast/events/pointerevents/touch-pointercancel.html View 4 chunks +34 lines, -2 lines 0 comments Download
M LayoutTests/fast/events/pointerevents/touch-pointercancel-expected.txt View 1 chunk +7 lines, -0 lines 0 comments Download
M LayoutTests/virtual/pointerevent/fast/events/pointerevents/touch-pointercancel-expected.txt View 1 chunk +15 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (6 generated)
mustaq
ptal
5 years, 3 months ago (2015-09-04 19:03:21 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1316013007/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1316013007/1
5 years, 3 months ago (2015-09-04 19:03:56 UTC) #3
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 3 months ago (2015-09-04 19:55:32 UTC) #5
mustaq
ptal
5 years, 3 months ago (2015-09-04 20:46:49 UTC) #7
Rick Byers
Nice, glad this just worked - thanks for adding the test. LGTM.
5 years, 3 months ago (2015-09-08 14:53:27 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1316013007/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1316013007/1
5 years, 3 months ago (2015-09-08 15:19:49 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_gn_chromeos_rel on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_gn_chromeos_rel/builds/79047)
5 years, 3 months ago (2015-09-08 15:52:35 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1316013007/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1316013007/1
5 years, 3 months ago (2015-09-08 18:46:06 UTC) #14
commit-bot: I haz the power
5 years, 3 months ago (2015-09-08 18:51:15 UTC) #15
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=201924

Powered by Google App Engine
This is Rietveld 408576698