extensions/shell/browser/shell_native_app_window.cc - Issue 1316013004: Remove "API proposal for chrome.app.window to intercept all keys."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/shell/browser/shell_native_app_window.cc

Issue 1316013004: Remove "API proposal for chrome.app.window to intercept all keys." (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Sync to TOT Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« extensions/common/permissions/api_permission.h ('K') | « extensions/shell/browser/shell_native_app_window.h ('k') | tools/metrics/histograms/histograms.xml » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: extensions/shell/browser/shell_native_app_window.cc

diff --git a/extensions/shell/browser/shell_native_app_window.cc b/extensions/shell/browser/shell_native_app_window.cc

index 911355613ca4f99d7337714f7497e3386555231f..83e76a7d4f8d3d5b0015919769778f9b168ea251 100644

--- a/extensions/shell/browser/shell_native_app_window.cc

+++ b/extensions/shell/browser/shell_native_app_window.cc

@@ -136,10 +136,6 @@ void ShellNativeAppWindow::UpdateShape(scoped_ptr<SkRegion> region) {

NOTIMPLEMENTED();

}

-void ShellNativeAppWindow::SetInterceptAllKeys(bool want_all_keys) {

- NOTIMPLEMENTED();

void ShellNativeAppWindow::HandleKeyboardEvent(

const content::NativeWebKeyboardEvent& event) {

// No special handling. The WebContents will handle it.