chrome/common/extensions/permissions/chrome_permission_message_rules.cc - Issue 1316013004: Remove "API proposal for chrome.app.window to intercept all keys."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/extensions/permissions/chrome_permission_message_rules.cc

Issue 1316013004: Remove "API proposal for chrome.app.window to intercept all keys." (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Sync to TOT Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/common/extensions/permissions/chrome_api_permissions.cc ('k') | chrome/test/data/extensions/platform_apps/window_api_intercept_all_keys/has_permission/main.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/common/extensions/permissions/chrome_permission_message_rules.cc

diff --git a/chrome/common/extensions/permissions/chrome_permission_message_rules.cc b/chrome/common/extensions/permissions/chrome_permission_message_rules.cc

index 2e050a27f256315ee5ce9a12f2f516a0e35c27ba..fc388e04997c8d29857e2fe0ea8c92fc8336d829 100644

--- a/chrome/common/extensions/permissions/chrome_permission_message_rules.cc

+++ b/chrome/common/extensions/permissions/chrome_permission_message_rules.cc

@@ -585,9 +585,6 @@ ChromePermissionMessageRule::GetAllRules() {

{IDS_EXTENSION_PROMPT_WARNING_DOCUMENT_SCAN,

{APIPermission::kDocumentScan},

{}},

- {IDS_EXTENSION_PROMPT_WARNING_INTERCEPT_ALL_KEYS,

- {APIPermission::kInterceptAllKeys},

- {}}, // TODO(treib): This should probably suppress kInput.

{IDS_EXTENSION_PROMPT_WARNING_INPUT, {APIPermission::kInput}, {}},

{IDS_EXTENSION_PROMPT_WARNING_MANAGEMENT,

{APIPermission::kManagement},