Remove "API proposal for chrome.app.window to intercept all keys."

Remove "API proposal for chrome.app.window to intercept all keys."

This reverts commit c811bb98b489b67a5f85ed79d7acd288533a080d.

The commit is reverted as it was decided to not add the API to platform.

Disabling presubmit to bypass enum edit check that fails as the enum value is renamed to kDelete_.

NOPRESUBMIT=true
BUG=166928
Committed: https://crrev.com/9daeacae81c70fe055af8d8a333691ca9a9fd181
Cr-Commit-Position: refs/heads/master@{#347960}

[Sriram, 2015-09-02 23:12:02]

sriramsr@chromium.org changed reviewers:
+ asvitkine@chromium.org, benwells@chromium.org

[Sriram, 2015-09-03 19:11:37]

Ping?

[Alexei Svitkine (slow), 2015-09-03 19:15:43]

lgtm, but don't know the context for the revert

[Sriram, 2015-09-03 19:19:59]

On 2015/09/03 19:15:43, Alexei Svitkine wrote:
> lgtm, but don't know the context for the revert

Thanks Alexei! I have updated the commit with reason for revert as well.
Basically we decided not to add this API to the platform.

[Marc Treib, 2015-09-04 07:28:34]

treib@chromium.org changed reviewers:
+ treib@chromium.org

[Marc Treib, 2015-09-04 07:28:35]

https://codereview.chromium.org/1316013004/diff/20001/extensions/common/permi...
File extensions/common/permissions/api_permission.h (right):

https://codereview.chromium.org/1316013004/diff/20001/extensions/common/permi...
extensions/common/permissions/api_permission.h:141: kInterceptAllKeys_unused,
nit: The common pattern would be
kDeleted_InterceptAllKeys

[Sriram, 2015-09-04 20:20:08]

Ping Ben?

https://codereview.chromium.org/1316013004/diff/20001/extensions/common/permi...
File extensions/common/permissions/api_permission.h (right):

https://codereview.chromium.org/1316013004/diff/20001/extensions/common/permi...
extensions/common/permissions/api_permission.h:141: kInterceptAllKeys_unused,
On 2015/09/04 07:28:35, Marc Treib wrote:
> nit: The common pattern would be
> kDeleted_InterceptAllKeys

Done.

[benwells, 2015-09-04 20:48:57]

Just to make sure, did you generate this revert via git, and then sync it to ToT
manually? Just trying to understand how manual / automatic this was.

I think the CL description should be 'remove' not 'revert', as I think of
'revert' as fully automatic reverts.

[Sriram, 2015-09-04 20:58:44]

On 2015/09/04 20:48:57, benwells wrote:
> Just to make sure, did you generate this revert via git, and then sync it to
ToT
> manually? Just trying to understand how manual / automatic this was.
> 
> I think the CL description should be 'remove' not 'revert', as I think of
> 'revert' as fully automatic reverts.

I started with git revert and then resolved conflict. I had to manually added
couple of files that have been moved since original checkin though.

[benwells, 2015-09-04 22:19:26]

lgtm

[Sriram, 2015-09-04 22:21:12]

Thanks Ben! 

Marc - do you want to take another look or is it okay to submit? 

Thanks,

[Marc Treib, 2015-09-07 07:30:31]

On 2015/09/04 22:21:12, Sriram wrote:
> Thanks Ben! 
> 
> Marc - do you want to take another look or is it okay to submit? 
> 
> Thanks,

LGTM!

[Sriram, 2015-09-08 16:37:14]

The CQ bit was checked by sriramsr@chromium.org

[Sriram, 2015-09-08 16:37:15]

The patchset sent to the CQ was uploaded after l-g-t-m from
asvitkine@chromium.org, benwells@chromium.org
Link to the patchset: https://codereview.chromium.org/1316013004/#ps80001
(title: "Sync to TOT in preparation to submit")

[commit-bot: I haz the power, 2015-09-08 16:37:44]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1316013004/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1316013004/80001

[commit-bot: I haz the power, 2015-09-08 16:47:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-09-08 16:47:55]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Sriram, 2015-09-08 18:57:44]

sriramsr@chromium.org changed reviewers:
+ sky@chromium.org

[Sriram, 2015-09-08 18:57:45]

Adding sky for OWNER approval for these files:
    chrome/browser/ui/BUILD.gn

[sky, 2015-09-08 22:15:23]

LGTM

[Sriram, 2015-09-08 22:17:58]

The CQ bit was checked by sriramsr@chromium.org

[commit-bot: I haz the power, 2015-09-08 22:18:29]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1316013004/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1316013004/80001

[commit-bot: I haz the power, 2015-09-08 22:32:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-09-08 22:32:41]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Marc Treib, 2015-09-09 11:39:23]

On 2015/09/08 22:32:41, commit-bot: I haz the power wrote:
> Try jobs failed on following builders:
>   chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
>
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

You'll have to skip presubmits (add "NOPRESUBMIT=true" to your CL description)
to get around the enum modification check. Please also add a brief comment why
you had to skip presubmit, thanks!

[Sriram, 2015-09-09 16:48:59]

On 2015/09/09 11:39:23, Marc Treib wrote:
> On 2015/09/08 22:32:41, commit-bot: I haz the power wrote:
> > Try jobs failed on following builders:
> >   chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
> >
>
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
> 
> You'll have to skip presubmits (add "NOPRESUBMIT=true" to your CL description)
> to get around the enum modification check. Please also add a brief comment why
> you had to skip presubmit, thanks!

Thanks Marc. I think we should fix the enum precheck to actually allow change to
prepend Delete. Do you know where the code is?

[Sriram, 2015-09-09 16:49:04]

The CQ bit was checked by sriramsr@chromium.org

[commit-bot: I haz the power, 2015-09-09 16:49:31]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1316013004/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1316013004/80001

[Sriram, 2015-09-09 16:50:49]

The CQ bit was unchecked by sriramsr@chromium.org

[Sriram, 2015-09-09 16:55:21]

The CQ bit was checked by sriramsr@chromium.org

[Sriram, 2015-09-09 16:55:22]

The patchset sent to the CQ was uploaded after l-g-t-m from treib@chromium.org,
benwells@chromium.org, asvitkine@chromium.org, sky@chromium.org
Link to the patchset: https://codereview.chromium.org/1316013004/#ps100001
(title: "Sync to TOT")

[commit-bot: I haz the power, 2015-09-09 16:55:49]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1316013004/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1316013004/100001

[Marc Treib, 2015-09-09 16:59:05]

On 2015/09/09 16:48:59, Sriram wrote:
> On 2015/09/09 11:39:23, Marc Treib wrote:
> > On 2015/09/08 22:32:41, commit-bot: I haz the power wrote:
> > > Try jobs failed on following builders:
> > >   chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
> > >
> >
>
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
> > 
> > You'll have to skip presubmits (add "NOPRESUBMIT=true" to your CL
description)
> > to get around the enum modification check. Please also add a brief comment
why
> > you had to skip presubmit, thanks!
> 
> Thanks Marc. I think we should fix the enum precheck to actually allow change
to
> prepend Delete. Do you know where the code is?

Starting point:
https://code.google.com/p/chromium/codesearch#chromium/src/extensions/common/...
I'm not convinced it's worth the extra complexity to extend the script -
"deleting" entries should be fairly rare. Your call though :)

[Sriram, 2015-09-09 17:01:51]

Infra-dev is already on the thread I posted on chromium-dev so will let
them make the call. Thanks Marc.

On Wed, Sep 9, 2015 at 9:59 AM, <treib@chromium.org> wrote:

> On 2015/09/09 16:48:59, Sriram wrote:
>
>> On 2015/09/09 11:39:23, Marc Treib wrote:
>> > On 2015/09/08 22:32:41, commit-bot: I haz the power wrote:
>> > > Try jobs failed on following builders:
>> > >   chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
>> > >
>> >
>>
>
>
>
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...
> )
>
>> >
>> > You'll have to skip presubmits (add "NOPRESUBMIT=true" to your CL
>>
> description)
>
>> > to get around the enum modification check. Please also add a brief
>> comment
>>
> why
>
>> > you had to skip presubmit, thanks!
>>
>
> Thanks Marc. I think we should fix the enum precheck to actually allow
>> change
>>
> to
>
>> prepend Delete. Do you know where the code is?
>>
>
> Starting point:
>
>
https://code.google.com/p/chromium/codesearch#chromium/src/extensions/common/...
> I'm not convinced it's worth the extra complexity to extend the script -
> "deleting" entries should be fairly rare. Your call though :)
>
> https://codereview.chromium.org/1316013004/
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[commit-bot: I haz the power, 2015-09-09 18:25:25]

Committed patchset #6 (id:100001)

[commit-bot: I haz the power, 2015-09-09 18:26:43]

Patchset 6 (id:??) landed as
https://crrev.com/9daeacae81c70fe055af8d8a333691ca9a9fd181
Cr-Commit-Position: refs/heads/master@{#347960}

[commit-bot: I haz the power, 2015-09-23 12:01:12]

Patchset 6 (id:??) landed as
https://crrev.com/9daeacae81c70fe055af8d8a333691ca9a9fd181
Cr-Commit-Position: refs/heads/master@{#347960}