Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(614)

Issue 1316013002: MSE: Refine WebM parser unit test MediaLog verification (Closed)

Created:
5 years, 3 months ago by wolenetz
Modified:
5 years, 3 months ago
Reviewers:
chcunningham, xhwang
CC:
chromium-reviews, feature-media-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@fix_and_reland_mse_webm_parser_medialog_verifications
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MSE: Refine WebM parser unit test MediaLog verification For the approx. 1500 combinations of Opus configurations involved in each of a couple WebMClusterParserTests, verifies expected MediaLog sequence for each, rather than just that the set of all logs matches the union of all expectations. Does this without regressing the tests' execution time, and allows early detection of failure to prevent test regression from building tremendous amount of failed expectations state. Similar state growth, though for otherwise passing tests, is suspected of causing test crashes on win7 dbg bots in original http://crrev.com/1300943002#ps40001. R=xhwang@chromium.org,chcunningham@chromium.org BUG=524597 TEST=WebMClusterParserTests: ReadOpusDurationsSimpleBlockAtEndOfCluster, and PreferOpusDurationsOverBlockDurations Committed: https://crrev.com/ba46024c5f48ffffaaea0e7d7c4a75a0ac6c5ae1 Cr-Commit-Position: refs/heads/master@{#345764}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -6 lines) Patch
M media/formats/webm/webm_cluster_parser_unittest.cc View 5 chunks +13 lines, -6 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 15 (5 generated)
wolenetz
Landing this will first depend on the prereq CL landing and not causing win7 dbg ...
5 years, 3 months ago (2015-08-26 00:37:25 UTC) #1
xhwang
lgtm
5 years, 3 months ago (2015-08-26 17:27:57 UTC) #2
chcunningham
lgtm
5 years, 3 months ago (2015-08-26 17:35:29 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1316013002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1316013002/1
5 years, 3 months ago (2015-08-26 17:52:35 UTC) #5
wolenetz
Thanks for reviews. Prereq CL is pending tree opening so I can watch it more ...
5 years, 3 months ago (2015-08-26 17:56:41 UTC) #7
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1316013002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1316013002/1
5 years, 3 months ago (2015-08-26 20:32:25 UTC) #9
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 3 months ago (2015-08-26 21:07:42 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1316013002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1316013002/1
5 years, 3 months ago (2015-08-27 01:49:40 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-08-27 01:55:22 UTC) #14
commit-bot: I haz the power
5 years, 3 months ago (2015-08-27 01:55:57 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ba46024c5f48ffffaaea0e7d7c4a75a0ac6c5ae1
Cr-Commit-Position: refs/heads/master@{#345764}

Powered by Google App Engine
This is Rietveld 408576698