Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3918)

Unified Diff: chrome/browser/resources/settings/prefs/prefs.js

Issue 1316003003: Add compiled_resources for settings/ and cr_elements/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@md_settings_compiled_resources_2
Patch Set: Feedback Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/settings/prefs/prefs.js
diff --git a/chrome/browser/resources/settings/prefs/prefs.js b/chrome/browser/resources/settings/prefs/prefs.js
index b68ccea3c5c9b26ee7608800145cf458189e34af..95ace2ea3ac32bfb523a3653e8ab312b76114ada 100644
--- a/chrome/browser/resources/settings/prefs/prefs.js
+++ b/chrome/browser/resources/settings/prefs/prefs.js
@@ -16,6 +16,16 @@
* @group Chrome Settings Elements
* @element cr-settings-a11y-page
*/
+
+/**
+ * TODO(stevenjb/michaelpg): Remove this once we stop using Object.observe.
+ * (that CL is in review, otherwise this doesn't really belong here).
+ * @param {!Object} object
+ * @param {!Function} callback
+ * @param {!Array<string>=} opt_acceptList
+ */
+Object.observe = function(object, callback, opt_acceptList) {};
+
(function() {
'use strict';
@@ -44,7 +54,8 @@
/**
* Called when prefs in the underlying Chrome pref store are changed.
- * @param {!Array<!PrefObject>} prefs The prefs that changed.
+ * @param {!Array<!chrome.settingsPrivate.PrefObject>} prefs The prefs that
+ * changed.
* @private
*/
onPrefsChanged_: function(prefs) {
@@ -53,7 +64,7 @@
/**
* Called when prefs are fetched from settingsPrivate.
- * @param {!Array<!PrefObject>} prefs
+ * @param {!Array<!chrome.settingsPrivate.PrefObject>} prefs
* @private
*/
onPrefsFetched_: function(prefs) {
@@ -66,7 +77,7 @@
/**
* Updates the settings model with the given prefs.
- * @param {!Array<!PrefObject>} prefs
+ * @param {!Array<!chrome.settingsPrivate.PrefObject>} prefs
* @param {boolean} shouldObserve Whether each of the prefs should be
* observed.
* @private
« no previous file with comments | « chrome/browser/resources/settings/prefs/compiled_resources.gyp ('k') | chrome/browser/resources/settings/prefs/prefs_types.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698