Add compiled_resources for settings/ and cr_elements/

Add compiled_resources for settings/ and cr_elements/

This also adds compiled_resources for settings/checkbox, settings/prefs, and cr_checkbox

These are pretty small right now but I hope to expand both
significantly soon, and think it would be better not to
have to change third_party/closure_compiler/compiled_resources
for every new element or settings page. (It will also avoid
a warning about updating the README when making a change in
third_party/)

BUG=none
CLOSED=https://codereview.chromium.org/1325893003/

[stevenjb, 2015-08-25 23:55:15]

stevenjb@chromium.org changed reviewers:
+ dbeam@chromium.org

[stevenjb, 2015-08-26 00:03:07]

No rush on this one, ptal when you have a moment.

[stevenjb, 2015-08-28 18:56:35]

Patchset #3 (id:40001) has been deleted

[stevenjb, 2015-08-28 19:24:16]

stevenjb@chromium.org changed reviewers:
+ michaelpg@chromium.org

[stevenjb, 2015-08-28 19:24:17]

I added settings/prefs also so that michael can compile his prefs changes.
PTAL when convenient.

[Dan Beam, 2015-08-28 20:32:26]

https://codereview.chromium.org/1316003003/diff/80001/chrome/browser/resource...
File chrome/browser/resources/settings/compiled_resources.gyp (right):

https://codereview.chromium.org/1316003003/diff/80001/chrome/browser/resource...
chrome/browser/resources/settings/compiled_resources.gyp:12:
'prefs/compiled_resources.gyp:*'
don't use tabs

https://codereview.chromium.org/1316003003/diff/80001/chrome/browser/resource...
File chrome/browser/resources/settings/prefs/prefs.js (right):

https://codereview.chromium.org/1316003003/diff/80001/chrome/browser/resource...
chrome/browser/resources/settings/prefs/prefs.js:21: * TODO(stevenjb/michaelpg):
Remove this once we stop using Object.observer.
observer -> observe

https://codereview.chromium.org/1316003003/diff/80001/chrome/browser/resource...
chrome/browser/resources/settings/prefs/prefs.js:27: Object.observe =
function(object, callback, opt_acceptList) {};
why can't we pull in es7_observe.js?

https://codereview.chromium.org/1316003003/diff/80001/chrome/browser/resource...
File chrome/browser/resources/settings/prefs/prefs_types.js (right):

https://codereview.chromium.org/1316003003/diff/80001/chrome/browser/resource...
chrome/browser/resources/settings/prefs/prefs_types.js:12: *    isInitialized:
(boolean|undefined)
indent off

https://codereview.chromium.org/1316003003/diff/80001/ui/webui/resources/cr_e...
File ui/webui/resources/cr_elements/v1_0/compiled_resources.gyp (right):

https://codereview.chromium.org/1316003003/diff/80001/ui/webui/resources/cr_e...
ui/webui/resources/cr_elements/v1_0/compiled_resources.gyp:11:
'network/compiled_resources.gyp:*',
tabs

[stevenjb, 2015-08-28 20:57:17]

https://codereview.chromium.org/1316003003/diff/80001/chrome/browser/resource...
File chrome/browser/resources/settings/compiled_resources.gyp (right):

https://codereview.chromium.org/1316003003/diff/80001/chrome/browser/resource...
chrome/browser/resources/settings/compiled_resources.gyp:12:
'prefs/compiled_resources.gyp:*'
On 2015/08/28 20:32:26, Dan Beam wrote:
> don't use tabs

Hm, oops. Have to teach my editor that for .gyp. Fixed.

https://codereview.chromium.org/1316003003/diff/80001/chrome/browser/resource...
File chrome/browser/resources/settings/prefs/prefs.js (right):

https://codereview.chromium.org/1316003003/diff/80001/chrome/browser/resource...
chrome/browser/resources/settings/prefs/prefs.js:21: * TODO(stevenjb/michaelpg):
Remove this once we stop using Object.observer.
On 2015/08/28 20:32:26, Dan Beam wrote:
> observer -> observe

Done.

https://codereview.chromium.org/1316003003/diff/80001/chrome/browser/resource...
chrome/browser/resources/settings/prefs/prefs.js:27: Object.observe =
function(object, callback, opt_acceptList) {};
On 2015/08/28 20:32:26, Dan Beam wrote:
> why can't we pull in es7_observe.js?

Didn't seem worth any effort for something that's about to go away.

https://codereview.chromium.org/1316003003/diff/80001/chrome/browser/resource...
File chrome/browser/resources/settings/prefs/prefs_types.js (right):

https://codereview.chromium.org/1316003003/diff/80001/chrome/browser/resource...
chrome/browser/resources/settings/prefs/prefs_types.js:12: *    isInitialized:
(boolean|undefined)
On 2015/08/28 20:32:26, Dan Beam wrote:
> indent off

Done.

https://codereview.chromium.org/1316003003/diff/80001/ui/webui/resources/cr_e...
File ui/webui/resources/cr_elements/v1_0/compiled_resources.gyp (right):

https://codereview.chromium.org/1316003003/diff/80001/ui/webui/resources/cr_e...
ui/webui/resources/cr_elements/v1_0/compiled_resources.gyp:11:
'network/compiled_resources.gyp:*',
On 2015/08/28 20:32:26, Dan Beam wrote:
> tabs

Done.

[stevenjb, 2015-08-28 20:59:27]

https://codereview.chromium.org/1316003003/diff/80001/chrome/browser/resource...
File chrome/browser/resources/settings/prefs/prefs.js (right):

https://codereview.chromium.org/1316003003/diff/80001/chrome/browser/resource...
chrome/browser/resources/settings/prefs/prefs.js:27: Object.observe =
function(object, callback, opt_acceptList) {};
On 2015/08/28 20:57:16, stevenjb wrote:
> On 2015/08/28 20:32:26, Dan Beam wrote:
> > why can't we pull in es7_observe.js?
> 
> Didn't seem worth any effort for something that's about to go away.

Also, I can wait for Michael's patch before landing this, I just wanted to put
it up so that Michael could use it to compile his patch.

[stevenjb, 2015-08-28 23:16:52]

If someone wants to take this over and upload it while I am gone so that we can
continue to expand our closure coverage, please feel free, otherwise I'll get
back to this when I return.

[michaelpg, 2015-09-01 23:48:50]

I'll take over and see if we can land this soon.

[Dan Beam, 2015-09-10 17:45:43]

so what's the status on this?  did michaelpg@ do this instead?  can we close
this review if it's not necessary?

[Dan Beam, 2015-09-10 17:45:57]

nevermind, I now see it's closed :)