chrome/chrome_browser_ui.gypi - Issue 13160004: Re-implement form validation message UI with native widgets. (Common and Mac)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/chrome_browser_ui.gypi

Issue 13160004: Re-implement form validation message UI with native widgets. (Common and Mac) (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: adddress review comments, and add a test Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/chrome_browser_ui.gypi

diff --git a/chrome/chrome_browser_ui.gypi b/chrome/chrome_browser_ui.gypi

index e012abdd73e3ae0598eb9f97bd465402590c1184..f06941c7f3c904e3ead28c84ca6d5258e6b202f2 100644

--- a/chrome/chrome_browser_ui.gypi

+++ b/chrome/chrome_browser_ui.gypi

@@ -101,6 +101,7 @@

'browser/ui/android/tab_model/tab_model_list.cc',

'browser/ui/android/tab_model/tab_model_list.h',

'browser/ui/android/tab_restore_service_delegate_android.cc',

+ 'browser/ui/android/validation_message_bubble_android.cc',

'browser/ui/android/website_settings_popup_android.cc',

'browser/ui/android/website_settings_popup_android.h',

'browser/ui/android/window_android_helper.cc',

@@ -842,6 +843,8 @@

'browser/ui/cocoa/ui_localizer.mm',

'browser/ui/cocoa/url_drop_target.h',

'browser/ui/cocoa/url_drop_target.mm',

+ 'browser/ui/cocoa/validation_message_bubble_cocoa.mm',

+ 'browser/ui/cocoa/validation_message_bubble_controller.h',

'browser/ui/cocoa/vertical_gradient_view.h',

'browser/ui/cocoa/vertical_gradient_view.mm',

'browser/ui/cocoa/view_id_util.h',

@@ -1177,6 +1180,7 @@

'browser/ui/gtk/unity_service.h',

'browser/ui/gtk/update_recommended_dialog.cc',

'browser/ui/gtk/update_recommended_dialog.h',

+ 'browser/ui/gtk/validation_message_bubble_gtk.cc',

'browser/ui/gtk/view_id_util.cc',

'browser/ui/gtk/view_id_util.h',

'browser/ui/gtk/web_contents_modal_dialog_manager_gtk.cc',

@@ -1435,6 +1439,7 @@

'browser/ui/unload_controller.cc',

'browser/ui/unload_controller.h',

'browser/ui/user_data_dir_dialog.h',

+ 'browser/ui/validation_message_bubble.h',

'browser/ui/view_ids.h',

'browser/ui/views/accelerator_utils_aura.cc',

'browser/ui/views/accelerator_utils_views.cc',

@@ -1834,6 +1839,7 @@

'browser/ui/views/outdated_upgrade_bubble_view.cc',

'browser/ui/views/user_data_dir_dialog_view.cc',

'browser/ui/views/user_data_dir_dialog_view.h',

+ 'browser/ui/views/validation_message_bubble_view.cc',

'browser/ui/views/web_contents_modal_dialog_manager_views.cc',

'browser/ui/views/website_settings/permission_selector_view.cc',

'browser/ui/views/website_settings/permission_selector_view.h',

« chrome/browser/ui/cocoa/validation_message_bubble_controller.h ('K') | « chrome/chrome_browser.gypi ('k') | chrome/chrome_common.gypi » ('j') | no next file with comments »