chrome/browser/ui/cocoa/base_bubble_controller.mm - Issue 13160004: Re-implement form validation message UI with native widgets. (Common and Mac)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/base_bubble_controller.mm

Issue 13160004: Re-implement form validation message UI with native widgets. (Common and Mac) (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: adddress review comments, and add a test Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/cocoa/base_bubble_controller.h ('k') | chrome/browser/ui/cocoa/validation_message_bubble_cocoa.mm » ('j') | chrome/browser/ui/cocoa/validation_message_bubble_controller.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/base_bubble_controller.mm

diff --git a/chrome/browser/ui/cocoa/base_bubble_controller.mm b/chrome/browser/ui/cocoa/base_bubble_controller.mm

index 375cb136a9c56222bcd11fb786783eb570941ebd..e81ce657d2b7ce86f6b15bc2e29a406c20651b89 100644

--- a/chrome/browser/ui/cocoa/base_bubble_controller.mm

+++ b/chrome/browser/ui/cocoa/base_bubble_controller.mm

@@ -28,6 +28,7 @@

@synthesize parentWindow = parentWindow_;

@synthesize anchorPoint = anchor_;

@synthesize bubble = bubble_;

+@synthesize shouldOpenAsKeyWindow = shouldOpenAsKeyWindow_;

- (id)initWithWindowNibPath:(NSString*)nibPath

parentWindow:(NSWindow*)parentWindow

@@ -44,6 +45,7 @@

selector:@selector(parentWindowWillClose:)

name:NSWindowWillCloseNotification

object:parentWindow_];

+ shouldOpenAsKeyWindow_ = YES;

}

return self;

}

@@ -86,6 +88,7 @@

object:parentWindow_];

[self awakeFromNib];

+ shouldOpenAsKeyWindow_ = YES;

Nico 2013/04/29 22:35:48 (likewise; probably at least want to do this befor

tkent 2013/04/29 23:08:01 Done.

}

return self;

}

@@ -148,7 +151,10 @@

NSWindow* window = [self window]; // Completes nib load.

[self updateOriginFromAnchor];

[parentWindow_ addChildWindow:window ordered:NSWindowAbove];

- [window makeKeyAndOrderFront:self];

+ if (shouldOpenAsKeyWindow_)

+ [window makeKeyAndOrderFront:self];

+ else

+ [window orderFront:nil];

[self registerKeyStateEventTap];

}