chrome/browser/chrome_content_browser_client.cc - Issue 13160004: Re-implement form validation message UI with native widgets. (Common and Mac)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chrome_content_browser_client.cc

Issue 13160004: Re-implement form validation message UI with native widgets. (Common and Mac) (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: adddress review comments, and add a test Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/chrome_content_browser_client.cc

diff --git a/chrome/browser/chrome_content_browser_client.cc b/chrome/browser/chrome_content_browser_client.cc

index af5a007d0303e75102d24265a070e750f95470f9..1ea80e37d4512ee9d80d6c64c5f0d5a3eefc4b60 100644

--- a/chrome/browser/chrome_content_browser_client.cc

+++ b/chrome/browser/chrome_content_browser_client.cc

@@ -78,6 +78,7 @@

#include "chrome/browser/ui/webui/sync_promo/sync_promo_ui.h"

#include "chrome/browser/user_style_sheet_watcher.h"

#include "chrome/browser/user_style_sheet_watcher_factory.h"

+#include "chrome/browser/validation_message_message_filter.h"

#include "chrome/common/child_process_logging.h"

#include "chrome/common/chrome_constants.h"

#include "chrome/common/chrome_paths.h"

@@ -726,6 +727,10 @@ void ChromeContentBrowserClient::RenderProcessHostCreated(

id, profile, context));

host->GetChannel()->AddFilter(

new prerender::PrerenderMessageFilter(id, profile));

+#if defined(OS_MACOSX)

+ // TODO(tkent): Enable it for other platforms.

+ host->GetChannel()->AddFilter(new ValidationMessageMessageFilter(id));

+#endif

host->Send(new ChromeViewMsg_SetIsIncognitoProcess(

profile->IsOffTheRecord()));

« no previous file with comments | « no previous file | chrome/browser/ui/android/validation_message_bubble_android.cc » ('j') | chrome/browser/ui/cocoa/base_bubble_controller.mm » ('J')