chrome/browser/ui/cocoa/base_bubble_controller.h - Issue 13160004: Re-implement form validation message UI with native widgets. (Common and Mac)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/base_bubble_controller.h

Issue 13160004: Re-implement form validation message UI with native widgets. (Common and Mac) (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Adopt new Blink interface Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/android/validation_message_bubble_android.cc ('k') | chrome/browser/ui/cocoa/base_bubble_controller.mm » ('j') | chrome/browser/ui/cocoa/base_bubble_controller.mm » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/base_bubble_controller.h

diff --git a/chrome/browser/ui/cocoa/base_bubble_controller.h b/chrome/browser/ui/cocoa/base_bubble_controller.h

index 2da9428eeb3777bb0c4fe4ea94ccb6c58a04d1c9..1339e9b2ba17d2e9cb8cd64a6da76a36f5eb695c 100644

--- a/chrome/browser/ui/cocoa/base_bubble_controller.h

+++ b/chrome/browser/ui/cocoa/base_bubble_controller.h

@@ -35,6 +35,9 @@ class TabStripModelObserverBridge;

id eventTap_;

// A notification observer that gets triggered when any window resigns key.

id resignationObserver_;

+ // The controlled window should be the key window when it's opened. True by

+ // default.

+ bool shouldOpenKeyWindow_;

Nico 2013/04/25 22:57:49 shouldOpenAsKeyWindow_

tkent 2013/04/29 22:24:19 Done.

}

@property(nonatomic, readonly) NSWindow* parentWindow;

@@ -42,6 +45,7 @@ class TabStripModelObserverBridge;

// arrow tip points.

@property(nonatomic, assign) NSPoint anchorPoint;

@property(nonatomic, readonly) InfoBubbleView* bubble;

+@property(nonatomic, assign) bool shouldOpenKeyWindow;

Nico 2013/04/25 22:57:49 likewise

tkent 2013/04/29 22:24:19 Done.

// Creates a bubble. |nibPath| is just the basename, e.g. @"FirstRunBubble".

// |anchoredAt| is in screen space. You need to call -showWindow: to make the