chrome/browser/ui/cocoa/validation_message_bubble_controller.h - Issue 13160004: Re-implement form validation message UI with native widgets. (Common and Mac)

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/ui/cocoa/validation_message_bubble_controller.h

Issue 13160004: Re-implement form validation message UI with native widgets. (Common and Mac) (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: adddress review comments, and add a test Created 7 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« chrome/browser/ui/cocoa/base_bubble_controller.mm ('K') | « chrome/browser/ui/cocoa/validation_message_bubble_cocoa.mm ('k') | chrome/browser/ui/cocoa/validation_message_bubble_controller_unittest.mm » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 // Copyright (c) 2013 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef CHROME_BROWSER_UI_COCOA_VALIDATION_MESSAGE_BUBBLE_CONTROLLER_H_

	6 #define CHROME_BROWSER_UI_COCOA_VALIDATION_MESSAGE_BUBBLE_CONTROLLER_H_

	7

	8 #include "base/string16.h"

	9 #import "chrome/browser/ui/cocoa/base_bubble_controller.h"

	10

	11 @interface ValidationMessageBubbleController : BaseBubbleController {
	Nico 2013/04/29 22:35:48 No need for the {}. Add a class comemnt. No need for the {}. Add a class comemnt. tkent 2013/04/29 23:08:01 Done. Show quoted text On 2013/04/29 22:35:48, Nico wrote: > No need for the {}. Add a class comemnt. Done.
	12 }

	13

	14 - (id)init:(NSWindow*)parentWindow

	15 anchoredAt:(NSPoint)anchorPoint

	16 mainText:(const string16&)mainText

	17 subText:(const string16&)subText;

	18

	19 // This is exposed for testing.

	20 + (NSView*)constructContentView:(const string16&)mainText

	21 subText:(const string16&)subText;

	22

	23 @end // interface ValidationMessageBubbleController
	Nico 2013/04/29 22:35:48 nit: We don't usually have comments on "@end" line nit: We don't usually have comments on "@end" lines I think (?) tkent 2013/04/29 23:08:01 Removed Removed
	24

	25 #endif // CHROME_BROWSER_UI_COCOA_VALIDATION_MESSAGE_BUBBLE_CONTROLLER_H_

OLD	NEW