Source/core/paint/ObjectPainter.cpp - Issue 1315993004: Implement a paint offset cache for slimming paint v2

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/paint/ObjectPainter.cpp

Issue 1315993004: Implement a paint offset cache for slimming paint v2 (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Fix bugs caught by unittest failures Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « Source/core/paint/MultiColumnSetPainter.cpp ('k') | Source/core/paint/PartPainter.cpp » ('j') | Source/platform/graphics/paint/DisplayItemList.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/paint/ObjectPainter.cpp

diff --git a/Source/core/paint/ObjectPainter.cpp b/Source/core/paint/ObjectPainter.cpp

index 3e96ff3dd80573bd7b68ca47a84bda586d44ee73..eb6bfd89b6c3f6174cb3738fb5d885bcf84ca263 100644

--- a/Source/core/paint/ObjectPainter.cpp

+++ b/Source/core/paint/ObjectPainter.cpp

@@ -31,12 +31,12 @@ void ObjectPainter::paintOutline(const PaintInfo& paintInfo, const LayoutRect& v

if (!styleToUse.hasOutline())

return;

- if (LayoutObjectDrawingRecorder::useCachedDrawingIfPossible(*paintInfo.context, m_layoutObject, paintInfo.phase))

+ if (LayoutObjectDrawingRecorder::useCachedDrawingIfPossible(*paintInfo.context, m_layoutObject, paintInfo.phase, paintOffset))

return;

LayoutRect visualOverflowBounds(visualOverflowRect);

visualOverflowBounds.moveBy(paintOffset);

- LayoutObjectDrawingRecorder recorder(*paintInfo.context, m_layoutObject, paintInfo.phase, visualOverflowBounds);

+ LayoutObjectDrawingRecorder recorder(*paintInfo.context, m_layoutObject, paintInfo.phase, visualOverflowBounds, paintOffset);

if (styleToUse.outlineStyleIsAuto()) {

if (LayoutTheme::theme().shouldDrawDefaultFocusRing(&m_layoutObject)) {

@@ -80,10 +80,10 @@ void ObjectPainter::addPDFURLRectIfNeeded(const PaintInfo& paintInfo, const Layo

if (rect.isEmpty())

return;

- if (LayoutObjectDrawingRecorder::useCachedDrawingIfPossible(*paintInfo.context, m_layoutObject, DisplayItem::PrintedContentPDFURLRect))

+ if (LayoutObjectDrawingRecorder::useCachedDrawingIfPossible(*paintInfo.context, m_layoutObject, DisplayItem::PrintedContentPDFURLRect, paintOffset))

return;

- LayoutObjectDrawingRecorder recorder(*paintInfo.context, m_layoutObject, DisplayItem::PrintedContentPDFURLRect, rect);

+ LayoutObjectDrawingRecorder recorder(*paintInfo.context, m_layoutObject, DisplayItem::PrintedContentPDFURLRect, rect, paintOffset);

if (url.hasFragmentIdentifier() && equalIgnoringFragmentIdentifier(url, m_layoutObject.document().baseURL())) {

String fragmentName = url.fragmentIdentifier();

if (m_layoutObject.document().findAnchor(fragmentName))

« no previous file with comments | « Source/core/paint/MultiColumnSetPainter.cpp ('k') | Source/core/paint/PartPainter.cpp » ('j') | Source/platform/graphics/paint/DisplayItemList.cpp » ('J')