Source/core/paint/ObjectPainter.h - Issue 1315993004: Implement a paint offset cache for slimming paint v2

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/paint/ObjectPainter.h

Issue 1315993004: Implement a paint offset cache for slimming paint v2 (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/core/paint/BlockFlowPainter.cpp ('K') | « Source/core/paint/MultiColumnSetPainter.cpp ('k') | Source/core/paint/ObjectPainter.cpp » ('j') | Source/platform/graphics/paint/DisplayItemList.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/paint/ObjectPainter.h

diff --git a/Source/core/paint/ObjectPainter.h b/Source/core/paint/ObjectPainter.h

index 555e3161f2ac7e0cac960b9949b1669a5f605636..72e3d62adca65ea4d5c21d348860b999478d4fba 100644

--- a/Source/core/paint/ObjectPainter.h

+++ b/Source/core/paint/ObjectPainter.h

@@ -22,7 +22,8 @@ class ObjectPainter {

public:

ObjectPainter(LayoutObject& layoutObject) : m_layoutObject(layoutObject) { }

- void paintOutline(const PaintInfo&, const LayoutRect& objectBounds, const LayoutRect& visualOverflowBounds);

+ // TODO(pdr): Update paintOutline to take a visualOverflowRect and a paintOffset and update the visual overflow in this function instead of at callsites.

+ void paintOutline(const PaintInfo&, const LayoutRect& objectBounds, const LayoutRect& visualOverflowBounds, const LayoutPoint& paintOffset);

void paintFocusRing(const PaintInfo&, const ComputedStyle&, const Vector<LayoutRect>& focusRingRects);

void addPDFURLRectIfNeeded(const PaintInfo&, const LayoutPoint& paintOffset);