Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Issue 1315993003: Reland: Change VideoCaptureDeliverFrameCB's signature (Closed)

Created:
5 years, 4 months ago by ajose
Modified:
5 years, 4 months ago
Reviewers:
mcasas
CC:
chromium-reviews, hclam+watch_chromium.org, posciak+watch_chromium.org, jam, imcheng+watch_chromium.org, mlamouri+watch-content_chromium.org, hguihot+watch_chromium.org, jasonroberts+watch_google.com, avayvod+watch_chromium.org, mcasas+watch_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, mkwst+moarreviews-renderer_chromium.org, wjia+watch_chromium.org, hubbe+watch_chromium.org, miu+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland: Change VideoCaptureDeliverFrameCB's signature Relanding https://codereview.chromium.org/1304393004/ Original description --------------------------------------------------- Change VideoCaptureDeliverFrameCB's signature from |const base::TimeTicks&| to |base::TimeTicks|. ------------------------------------------------------------------------ TBR=dalecurtis@chromium.org, bbudge@chromium.org Rationale: already LGTMd PS1, new changes resulted from collision with mcasas@'s code while landing. BUG=524589, 524719 Committed: https://crrev.com/809c2ecbb948cc20cf7bfc847823f1bdadfd855f Cr-Commit-Position: refs/heads/master@{#345497}

Patch Set 1 : (original patch) #

Patch Set 2 : address new changes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -29 lines) Patch
M chrome/renderer/media/cast_rtp_stream.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/media/media_stream_video_capture_source_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/media/media_stream_video_track.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/renderer/media/media_stream_video_track_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/media/mock_media_stream_video_sink.h View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/media/mock_media_stream_video_sink.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/media/rtc_video_renderer.h View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/media/rtc_video_renderer.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/media/video_capture_impl_manager_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/media/video_capture_impl_unittest.cc View 1 chunk +1 line, -2 lines 0 comments Download
M content/renderer/media/video_source_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/media/video_track_adapter.h View 1 chunk +2 lines, -3 lines 0 comments Download
M content/renderer/media/video_track_adapter.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/media/video_track_recorder.h View 1 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/media/video_track_recorder.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/media/webrtc/webrtc_video_track_adapter.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/renderer/pepper/pepper_media_stream_video_track_host.h View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/pepper/pepper_media_stream_video_track_host.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/pepper/pepper_platform_video_capture.h View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/pepper/pepper_platform_video_capture.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/base/video_capturer_source.h View 1 chunk +3 lines, -4 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
ajose
TBR=dalecurtis@chromium.org, bbudge@chromium.org Rationale: already LGTMd PS1, new changes resulted from collision with mcasas@'s code while ...
5 years, 4 months ago (2015-08-25 23:09:31 UTC) #2
mcasas
lgtm
5 years, 4 months ago (2015-08-25 23:39:59 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1315993003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1315993003/20001
5 years, 4 months ago (2015-08-25 23:42:23 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 4 months ago (2015-08-26 00:14:53 UTC) #6
commit-bot: I haz the power
5 years, 4 months ago (2015-08-26 00:15:53 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/809c2ecbb948cc20cf7bfc847823f1bdadfd855f
Cr-Commit-Position: refs/heads/master@{#345497}

Powered by Google App Engine
This is Rietveld 408576698