Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2008)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1315993002: [simd.js] Clean up bad merge in messages.js (Closed)

Created:
5 years, 4 months ago by bbudge
Modified:
5 years, 4 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[simd.js] Clean up bad merge in messages.js Eliminates duplicate var's and assignments. LOG=N BUG=v8:4124 Committed: https://crrev.com/48276d34daa640eb1ca924561dd5dfb2636f6422 Cr-Commit-Position: refs/heads/master@{#30366}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -20 lines) Patch
M src/messages.js View 1 3 chunks +6 lines, -20 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
bbudge
5 years, 4 months ago (2015-08-25 20:46:45 UTC) #2
Dan Ehrenberg
lgtm Oops!
5 years, 4 months ago (2015-08-26 01:10:27 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1315993002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1315993002/20001
5 years, 4 months ago (2015-08-26 01:13:22 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 4 months ago (2015-08-26 01:15:03 UTC) #7
commit-bot: I haz the power
5 years, 4 months ago (2015-08-26 01:15:13 UTC) #8
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/48276d34daa640eb1ca924561dd5dfb2636f6422
Cr-Commit-Position: refs/heads/master@{#30366}

Powered by Google App Engine
This is Rietveld 408576698