LayoutTests/editing/selection/longpress-selection-in-iframe-removed-crash.html - Issue 1315983004: Fix use-after-free bug in long press selection

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/editing/selection/longpress-selection-in-iframe-removed-crash.html

Issue 1315983004: Fix use-after-free bug in long press selection (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Address review feedback Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2
	yosin_UTC9 2015/09/01 01:33:29 nit: We don't need to have an extra blank line. nit: We don't need to have an extra blank line. majidvp 2015/09/01 15:33:53 Done. Show quoted text On 2015/09/01 01:33:29, Yosi_UTC9 wrote: > nit: We don't need to have an extra blank line. Done.
	3 <script src="../../resources/testharness.js"></script>

	4 <script src="../../resources/testharnessreport.js"></script>

	5 <script type="text/javascript">

	6 "use strict";
	yosin_UTC9 2015/09/01 01:33:29 nit: We don't need to have "use strict", because t nit: We don't need to have "use strict", because this crash occurs regardless strict mode or not. majidvp 2015/09/01 15:33:53 That is correct. Given it is irrelevant I prefer t Show quoted text On 2015/09/01 01:33:29, Yosi_UTC9 wrote: > nit: We don't need to have "use strict", because this crash occurs regardless > strict mode or not. That is correct. Given it is irrelevant I prefer to keep the strict mode. I couldn't find any recommendation for or against it in style guide.
	7

	8 async_test(function(t) {

	9 document.addEventListener("DOMContentLoaded", t.step_func(function() {

	10 var iframe1 = document.createElementNS("http://www.w3.org/1999/xhtml", "if rame");

	11 iframe1.setAttribute("srcdoc", "ABC");

	12 document.documentElement.appendChild(iframe1);

	13 var document1 = document.implementation.createDocument("", null);

	14 iframe1.addEventListener("DOMFocusOut", function() {

	15 document1.adoptNode(iframe1);

	16 });

	17 iframe1.focus();

	18

	19 iframe1.addEventListener("load", t.step_func(function() {

	20 document.designMode = "on";

	21

	22 var clientRect = iframe1.getBoundingClientRect();

	23 var x = clientRect.left + 10;

	24 var y = clientRect.top + 10;

	25 if (window.eventSender)
	yosin_UTC9 2015/09/01 01:33:29 nit: It is better to check \|window.eventSender\| at nit: It is better to check \|window.eventSender\| at top of this function. majidvp 2015/09/01 15:33:53 Done. Show quoted text On 2015/09/01 01:33:29, Yosi_UTC9 wrote: > nit: It is better to check \|window.eventSender\| at top of this function. Done.
	26 eventSender.gestureLongPress(x, y);

	27 else

	28 assert_unreached("This test requires window.eventSender to exist");

	29

	30 // Test passes if it does not crash and reaches this point

	31 setTimeout(t.done.bind(t), 0);

	32 }));

	33 }));

	34 }, "Test longpress selection does not crash");

	35 </script>

OLD	NEW

« no previous file with comments | « no previous file | Source/core/input/EventHandler.cpp » ('j') | no next file with comments »