Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Unified Diff: Source/core/xml/XPathPath.h

Issue 131593003: Fix bad cast to XPath::Filter in XPathGrammar.y (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/xml/XPathGrammar.y ('k') | Source/core/xml/XPathPath.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/xml/XPathPath.h
diff --git a/Source/core/xml/XPathPath.h b/Source/core/xml/XPathPath.h
index f50192647cf37854810581ede8f361e0b0b9f107..18016a8500f714deebb98207cabf669482625da0 100644
--- a/Source/core/xml/XPathPath.h
+++ b/Source/core/xml/XPathPath.h
@@ -37,50 +37,50 @@ namespace WebCore {
class Predicate;
class Step;
- class Filter : public Expression {
+ class Filter FINAL : public Expression {
public:
Filter(PassOwnPtr<Expression>, Vector<OwnPtr<Predicate> >&);
virtual ~Filter();
- virtual Value evaluate() const;
+ virtual Value evaluate() const OVERRIDE;
private:
- virtual Value::Type resultType() const { return Value::NodeSetValue; }
+ virtual Value::Type resultType() const OVERRIDE { return Value::NodeSetValue; }
OwnPtr<Expression> m_expr;
Vector<OwnPtr<Predicate> > m_predicates;
};
- class LocationPath : public Expression {
+ class LocationPath FINAL : public Expression {
public:
LocationPath();
virtual ~LocationPath();
void setAbsolute(bool value) { m_absolute = value; setIsContextNodeSensitive(!m_absolute); }
- virtual Value evaluate() const;
+ virtual Value evaluate() const OVERRIDE;
void evaluate(NodeSet& nodes) const; // nodes is an input/output parameter
void appendStep(Step* step);
void insertFirstStep(Step* step);
private:
- virtual Value::Type resultType() const { return Value::NodeSetValue; }
+ virtual Value::Type resultType() const OVERRIDE { return Value::NodeSetValue; }
Vector<Step*> m_steps;
bool m_absolute;
};
- class Path : public Expression {
+ class Path FINAL : public Expression {
public:
- Path(Filter*, LocationPath*);
+ Path(Expression*, LocationPath*);
virtual ~Path();
- virtual Value evaluate() const;
+ virtual Value evaluate() const OVERRIDE;
private:
- virtual Value::Type resultType() const { return Value::NodeSetValue; }
+ virtual Value::Type resultType() const OVERRIDE { return Value::NodeSetValue; }
- Filter* m_filter;
+ Expression* m_filter;
LocationPath* m_path;
};
« no previous file with comments | « Source/core/xml/XPathGrammar.y ('k') | Source/core/xml/XPathPath.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698