Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(263)

Issue 1315903005: MIPS: Refine '[es6] Introduce a dedicated JSIteratorResult type.' (Closed)

Created:
5 years, 3 months ago by balazs.kilvady
Modified:
5 years, 3 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

MIPS: Refine '[es6] Introduce a dedicated JSIteratorResult type.' Port 72bc4b5c8a5c4279bcb8b340edbc8aa1c46d75a1 Original commit message: Use a single JSIteratorResult type for all implementation provided iterator results (i.e. the String, Array and collection iterators, and also for generators). This removes one source of unnecessary polymorphism in for-of loops. It is accomplished by a new intrinsic %_CreateIterResultObject() that should be used to create iterator result objects from JavaScript builtins (there's a matching factory method for C++ code). Also restructure the %StringIteratorPrototype%.next() and %ArrayIteratorPrototype%.next() functions to be a bit more friendly to optimizing compilers. BUG= Committed: https://crrev.com/29a2e8f861bdb1be40704205027becac1c4e72e5 Cr-Commit-Position: refs/heads/master@{#30572}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -14 lines) Patch
M src/full-codegen/mips/full-codegen-mips.cc View 2 chunks +5 lines, -5 lines 0 comments Download
M src/full-codegen/mips64/full-codegen-mips64.cc View 2 chunks +9 lines, -9 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
balazs.kilvady
5 years, 3 months ago (2015-09-03 15:49:16 UTC) #2
paul.l...
LGTM. FYI, for Benedikt and v8 team, LoadRoot() is preferred over li() where possible, since ...
5 years, 3 months ago (2015-09-03 16:41:42 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1315903005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1315903005/1
5 years, 3 months ago (2015-09-03 17:00:11 UTC) #5
Benedikt Meurer
> FYI, for Benedikt and v8 team, LoadRoot() is preferred over li() where possible, > ...
5 years, 3 months ago (2015-09-03 17:39:40 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-03 17:51:21 UTC) #7
commit-bot: I haz the power
5 years, 3 months ago (2015-09-03 17:51:41 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/29a2e8f861bdb1be40704205027becac1c4e72e5
Cr-Commit-Position: refs/heads/master@{#30572}

Powered by Google App Engine
This is Rietveld 408576698