rietveld.py - Issue 1315893002: get_depends_on_patchset is actually a POST endpoint

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: rietveld.py

Issue 1315893002: get_depends_on_patchset is actually a POST endpoint (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/depot_tools.git@master

Patch Set: Initial upload Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: rietveld.py

diff --git a/rietveld.py b/rietveld.py

index ec5d7814468dbf60afb31e3ec036173163ac9f81..1c569fc9bb1c51a6319cc1caee75f598f161ddce 100644

--- a/rietveld.py

+++ b/rietveld.py

@@ -89,7 +89,7 @@ class Rietveld(object):

url = '/%d/patchset/%d/get_depends_on_patchset' % (issue, patchset)

resp = None

try:

- resp = json.loads(self.get(url))

+ resp = json.loads(self.post(url, []))

except (urllib2.HTTPError, ValueError):

# The get_depends_on_patchset endpoint does not exist on this Rietveld

# instance yet. Ignore the error and proceed.

« no previous file with comments | « no previous file | no next file » | no next file with comments »