Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(247)

Issue 1315873003: Fix BOM handling w/ bookmark + streaming parsing. (Closed)

Created:
5 years, 3 months ago by vogelheim
Modified:
5 years, 3 months ago
CC:
blink-reviews, blink-reviews-bindings_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Fix BOM handling w/ bookmark + streaming parsing. Previously, resetting a bookmark in a file with BOM would not account for the BOM length, meaning the parser would be off by 2 (UCS2) or 3 (UTF-8) bytes. Additional information in the comments and in the referenced bug. It's not an off-by-1 error, it's an off-by-O(1) error. R=jochen@chromium.org BUG=527930 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201915

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -2 lines) Patch
M Source/bindings/core/v8/ScriptStreamer.cpp View 5 chunks +26 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
vogelheim
5 years, 3 months ago (2015-09-08 09:05:26 UTC) #1
jochen (gone - plz use gerrit)
lgtm
5 years, 3 months ago (2015-09-08 12:20:43 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1315873003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1315873003/1
5 years, 3 months ago (2015-09-08 13:35:58 UTC) #4
commit-bot: I haz the power
5 years, 3 months ago (2015-09-08 14:45:55 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=201915

Powered by Google App Engine
This is Rietveld 408576698