Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(819)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1315833007: Revert of [Android] Add gyp support for multidex. (Closed)

Created:
5 years, 4 months ago by jbudorick
Modified:
5 years, 4 months ago
Reviewers:
cjhopman, Yaron, Nico, agrieve, mmenke
CC:
chromium-reviews, jbudorick+watch_chromium.org, klundberg+watch_chromium.org, yfriedman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [Android] Add gyp support for multidex. (patchset #12 id:220001 of https://codereview.chromium.org/1278573002/ ) Reason for revert: Somehow broke compilation on the main waterfall: https://build.chromium.org/p/chromium/builders/Android/builds/45388 Original issue's description: > [Android] Add gyp support for multidex. > > Note that this does not enable multidex builds yet. > > BUG=272790 > > Committed: https://crrev.com/e40294eca50d57360a2bb0718adcd5cde7810fbd > Cr-Commit-Position: refs/heads/master@{#345357} TBR=agrieve@chromium.org,cjhopman@chromium.org,mmenke@chromium.org,thakis@chromium.org,yfriedman@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=272790 Committed: https://crrev.com/6daf3a522276748b2f69144f63db76a62a30d014 Cr-Commit-Position: refs/heads/master@{#345370}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -457 lines) Patch
M base/BUILD.gn View 2 chunks +1 line, -19 lines 0 comments Download
M base/android/java/src/org/chromium/base/BaseChromiumApplication.java View 2 chunks +0 lines, -11 lines 0 comments Download
D base/android/java/src/org/chromium/base/annotations/MainDex.java View 1 chunk +0 lines, -21 lines 0 comments Download
D base/android/java/src/org/chromium/base/multidex/ChromiumMultiDex.java View 1 chunk +0 lines, -56 lines 0 comments Download
M base/android/junit/src/org/chromium/base/BaseChromiumApplicationTest.java View 2 chunks +2 lines, -5 lines 0 comments Download
M base/base.gyp View 2 chunks +0 lines, -19 lines 0 comments Download
M base/test/android/javatests/src/org/chromium/base/test/BaseInstrumentationTestRunner.java View 3 chunks +0 lines, -8 lines 0 comments Download
D base/test/android/junit/src/org/chromium/base/test/shadows/ShadowMultiDex.java View 1 chunk +0 lines, -21 lines 0 comments Download
M build/android/ant/apk-package.xml View 3 chunks +2 lines, -31 lines 0 comments Download
M build/android/apkbuilder_action.gypi View 1 chunk +0 lines, -5 lines 0 comments Download
M build/android/gyp/dex.py View 3 chunks +2 lines, -50 lines 0 comments Download
D build/android/gyp/main_dex_list.py View 1 chunk +0 lines, -84 lines 0 comments Download
D build/android/main_dex_action.gypi View 1 chunk +0 lines, -44 lines 0 comments Download
D build/android/main_dex_classes.flags View 1 chunk +0 lines, -3 lines 0 comments Download
M build/android/pylib/constants/__init__.py View 1 chunk +0 lines, -3 lines 0 comments Download
M build/config/android/rules.gni View 1 chunk +0 lines, -3 lines 0 comments Download
M build/java.gypi View 3 chunks +0 lines, -10 lines 0 comments Download
M build/java_apk.gypi View 9 chunks +4 lines, -48 lines 0 comments Download
M build/secondary/third_party/android_tools/BUILD.gn View 1 chunk +0 lines, -5 lines 0 comments Download
M chrome/android/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/android/junit/src/org/chromium/chrome/browser/media/remote/AbstractMediaRouteControllerTest.java View 2 chunks +2 lines, -3 lines 0 comments Download
M chrome/chrome_tests.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M net/android/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M net/android/junit/src/org/chromium/net/HttpNegotiateAuthenticatorTest.java View 2 chunks +3 lines, -4 lines 0 comments Download
M net/net.gyp View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
jbudorick
Created Revert of [Android] Add gyp support for multidex.
5 years, 4 months ago (2015-08-25 17:38:56 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1315833007/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1315833007/1
5 years, 4 months ago (2015-08-25 17:39:53 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-08-25 17:42:40 UTC) #3
commit-bot: I haz the power
5 years, 4 months ago (2015-08-25 17:43:51 UTC) #4
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/6daf3a522276748b2f69144f63db76a62a30d014
Cr-Commit-Position: refs/heads/master@{#345370}

Powered by Google App Engine
This is Rietveld 408576698