Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Issue 1315813003: Make EditorCommand to use VisibleSelection::toNormalizedEphemeralRange() instead of toNormalizedRang (Closed)

Created:
5 years, 3 months ago by yosin_UTC9
Modified:
5 years, 3 months ago
Reviewers:
yoichio, hajimehoshi, yosin
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Make EditorCommand to use VisibleSelection::toNormalizedEphemeralRange() instead of toNormalizedRange() This patch changes |EditorCOmmand| class to use |toNormalizedEphemeralRange()| in |VisibleSelection| class instead of |toNormalizedRange()| as a preparation of templatizing |VisibleSelection| to use templatized positions instead of DOM position to represent range and avoid registering temporary |Range| object into |Document|. This patch is a preparation of making selection to handle granularity for web component, http://crrev.com/1277863002 BUG=388681, 513568 TEST=n/a; no behavior changes Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201127

Patch Set 1 : 2015-08-25T15:39:00 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -10 lines) Patch
M Source/core/editing/commands/EditorCommand.cpp View 2 chunks +6 lines, -10 lines 0 comments Download

Messages

Total messages: 14 (6 generated)
yosin_UTC9
PTAL
5 years, 3 months ago (2015-08-25 07:04:09 UTC) #2
yoichio
lgtm
5 years, 3 months ago (2015-08-25 07:33:05 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1315813003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1315813003/1
5 years, 3 months ago (2015-08-25 07:41:49 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/103685)
5 years, 3 months ago (2015-08-25 08:37:28 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1315813003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1315813003/1
5 years, 3 months ago (2015-08-25 09:21:33 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/103747)
5 years, 3 months ago (2015-08-25 10:23:36 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1315813003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1315813003/1
5 years, 3 months ago (2015-08-25 10:30:52 UTC) #13
commit-bot: I haz the power
5 years, 3 months ago (2015-08-25 11:39:00 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=201127

Powered by Google App Engine
This is Rietveld 408576698