src/heap.cc - Issue 13158002: Always allocate symbols in old space.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/heap.cc

Issue 13158002: Always allocate symbols in old space. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Created 7 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/heap.cc

diff --git a/src/heap.cc b/src/heap.cc

index 7c9a7fd63262f5168bb33482c456e6cf0bf3f6e7..ebf9c08b9f8da6623a9b0b846f369ce8201b41ce 100644

--- a/src/heap.cc

+++ b/src/heap.cc

@@ -5428,10 +5428,10 @@ MaybeObject* Heap::AllocateHashTable(int length, PretenureFlag pretenure) {

}

-MaybeObject* Heap::AllocateSymbol(PretenureFlag pretenure) {

+MaybeObject* Heap::AllocateSymbol() {

// Statically ensure that it is safe to allocate symbols in paged spaces.

STATIC_ASSERT(Symbol::kSize <= Page::kNonCodeObjectAreaSize);

- AllocationSpace space = pretenure == TENURED ? OLD_POINTER_SPACE : NEW_SPACE;

+ AllocationSpace space = OLD_POINTER_SPACE;

rossberg 2013/03/28 13:33:17 Nit: just inline this now trivial definition.

Object* result;

MaybeObject* maybe = AllocateRaw(Symbol::kSize, space, OLD_POINTER_SPACE);