Web MIDI: introduce MidiManager::Shutdown to shutdown gracefully

content/browser/browser_main_loop.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/browser_main_loop.h"
 
 #include "base/bind.h"
 #include "base/command_line.h"
 #include "base/location.h"
 #include "base/logging.h"
@@ skipping 671 matching lines @@
         chromeos::switches::GetMemoryPressureThresholds()));
   }
 #elif defined(OS_MACOSX) && !defined(OS_IOS)
   memory_pressure_monitor_.reset(new base::mac::MemoryPressureMonitor());
 #elif defined(OS_WIN)
   memory_pressure_monitor_.reset(CreateWinMemoryPressureMonitor(
       parsed_command_line_));
 #endif
 
 #if defined(ENABLE_PLUGINS)
-  // Prior to any processing happening on the io thread, we create the
-  // plugin service as it is predominantly used from the io thread,
+  // Prior to any processing happening on the IO thread, we create the
+  // plugin service as it is predominantly used from the IO thread,
   // but must be created on the main thread. The service ctor is

[kinuko, 2015/10/05 08:56:32]

(are these changes related?)

[Takashi Toyoshima, 2015/10/05 16:11:05]

Yeah, I just want to make the term consistent with other places. This comment is
the only place to say "io thread" instead of "IO thread".

   // inexpensive and does not invoke the io_thread() accessor.
   {
     TRACE_EVENT0("startup", "BrowserMainLoop::CreateThreads:PluginService");
     PluginService::GetInstance()->Init();
   }
 #endif
 
 #if defined(OS_MACOSX)
   {
     // Initialize AVFoundation if supported, for audio and video.
@@ skipping 248 matching lines @@
   // stopping the GPU thread. The GPU thread will close IPC channels to renderer
   // processes so this has to happen before stopping the IO thread.
   {
     TRACE_EVENT0("shutdown", "BrowserMainLoop::Subsystem:GPUProcessHostShim");
     GpuProcessHostUIShim::DestroyAll();
   }
   // Cancel pending requests and prevent new requests.
   if (resource_dispatcher_host_) {
     TRACE_EVENT0("shutdown",
                  "BrowserMainLoop::Subsystem:ResourceDispatcherHost");
-    resource_dispatcher_host_.get()->Shutdown();
+    resource_dispatcher_host_->Shutdown();
+  }
+  // Request shutdown to clean up allocated resources on the IO thread.

[Takashi Toyoshima, 2015/10/05 16:11:05]

I noticed that when I wrote this comment.

+  if (midi_manager_) {
+    TRACE_EVENT0("shutdown", "BrowserMainLoop::Subsystem:MidiManager");
+    midi_manager_->Shutdown();
   }
 
   memory_pressure_monitor_.reset();
 
 #if defined(OS_MACOSX)
   BrowserCompositorMac::DisableRecyclingForShutdown();
 #endif
 
 #if defined(USE_AURA) || defined(OS_MACOSX)
   {
@@ skipping 418 matching lines @@
   DCHECK(is_tracing_startup_for_duration_);
 
   is_tracing_startup_for_duration_ = false;
   TracingController::GetInstance()->DisableRecording(
       TracingController::CreateFileSink(
           startup_trace_file_,
           base::Bind(OnStoppedStartupTracing, startup_trace_file_)));
 }
 
 }  // namespace content