Web MIDI: introduce MidiManager::Shutdown to shutdown gracefully

media/midi/midi_manager.cc

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "media/midi/midi_manager.h"
 
 #include "base/bind.h"
 #include "base/message_loop/message_loop.h"
 #include "base/metrics/histogram_macros.h"
 #include "base/trace_event/trace_event.h"
@@ skipping 25 matching lines @@
 
 void ReportUsage(Usage usage) {
   UMA_HISTOGRAM_ENUMERATION("Media.Midi.Usage",
                             static_cast<Sample>(usage),
                             static_cast<Sample>(Usage::MAX) + 1);
 }
 
 }  // namespace
 
 MidiManager::MidiManager()
-    : initialized_(false), result_(Result::NOT_INITIALIZED) {
+    : initialized_(false), finalized_(false), result_(Result::NOT_INITIALIZED) {
   ReportUsage(Usage::CREATED);
 }
 
 MidiManager::~MidiManager() {
-  UMA_HISTOGRAM_ENUMERATION("Media.Midi.ResultOnShutdown",
-                            static_cast<Sample>(result_),
-                            static_cast<Sample>(Result::MAX) + 1);
+  // Make sure that Finalize() is called to clean up resources allocated on
+  // the Chrome_IOThread.
+  DCHECK(finalized_);
 }
 
 #if !defined(OS_MACOSX) && !defined(OS_WIN) && \
     !(defined(USE_ALSA) && defined(USE_UDEV)) && !defined(OS_ANDROID)
 MidiManager* MidiManager::Create() {
   ReportUsage(Usage::CREATED_ON_UNSUPPORTED_PLATFORMS);
   return new MidiManager;
 }
 #endif
 
+void MidiManager::Shutdown() {
+  UMA_HISTOGRAM_ENUMERATION("Media.Midi.ResultOnShutdown",
+                            static_cast<int>(result_),
+                            static_cast<int>(Result::MAX) + 1);
+  base::AutoLock auto_lock(lock_);
+  if (session_thread_runner_) {
+    session_thread_runner_->PostTask(
+        FROM_HERE, base::Bind(&MidiManager::ShutdownOnSessionThread,
+                              base::Unretained(this)));
+    session_thread_runner_ = nullptr;
+  } else {
+    finalized_ = true;
+  }
+}
+
 void MidiManager::StartSession(MidiManagerClient* client) {
   ReportUsage(Usage::SESSION_STARTED);
 
   bool session_is_ready;
   bool session_needs_initialization = false;
   bool too_many_pending_clients_exist = false;
 
   {
     base::AutoLock auto_lock(lock_);
     session_is_ready = initialized_;
@@ skipping 14 matching lines @@
         session_needs_initialization = pending_clients_.empty();
         pending_clients_.insert(client);
       }
     }
   }
 
   // Lazily initialize the MIDI back-end.
   if (!session_is_ready) {
     if (session_needs_initialization) {
       TRACE_EVENT0("midi", "MidiManager::StartInitialization");
-      session_thread_runner_ =
-          base::MessageLoop::current()->task_runner();
+      {
+        base::AutoLock auto_lock(lock_);
+        // Stop calling StartInitialization() if Shutdown() was already called.
+        if (finalized_)

[yhirano, 2015/09/11 15:59:47]

Should we call CompleteStartSession with INITIALIZATION_ERROR?

[Takashi Toyoshima, 2015/09/17 07:30:49]

This isn't easy because I do not want to call client callback inside a lock. Let
me clean up StartSession().

+          return;
+        session_thread_runner_ = base::MessageLoop::current()->task_runner();
+      }
       StartInitialization();
     }
     if (too_many_pending_clients_exist) {
       // Return an error immediately if there are too many requests.
       client->CompleteStartSession(Result::INITIALIZATION_ERROR);
       return;
     }
     // CompleteInitialization() will be called asynchronously when platform
     // dependent initialization is finished.
     return;
@@ skipping 37 matching lines @@
                                        const std::vector<uint8>& data,
                                        double timestamp) {
   NOTREACHED();
 }
 
 void MidiManager::StartInitialization() {
   CompleteInitialization(Result::NOT_SUPPORTED);
 }
 
 void MidiManager::CompleteInitialization(Result result) {
-  DCHECK(session_thread_runner_.get());
-  // It is safe to post a task to the IO thread from here because the IO thread
-  // should have stopped if the MidiManager is going to be destructed.
-  session_thread_runner_->PostTask(
-      FROM_HERE,
-      base::Bind(&MidiManager::CompleteInitializationInternal,
-                 base::Unretained(this),
-                 result));
+  base::AutoLock auto_lock(lock_);
+  if (session_thread_runner_) {
+    session_thread_runner_->PostTask(
+        FROM_HERE, base::Bind(&MidiManager::CompleteInitializationInternal,
+                              base::Unretained(this), result));
+  }
 }
 
 void MidiManager::AddInputPort(const MidiPortInfo& info) {
   ReportUsage(Usage::INPUT_PORT_ADDED);
   base::AutoLock auto_lock(lock_);
   input_ports_.push_back(info);
   for (auto client : clients_)
     client->AddInputPort(info);
 }
 
@@ skipping 60 matching lines @@
 
 void MidiManager::AddInitialPorts(MidiManagerClient* client) {
   lock_.AssertAcquired();
 
   for (const auto& info : input_ports_)
     client->AddInputPort(info);
   for (const auto& info : output_ports_)
     client->AddOutputPort(info);
 }
 
+void MidiManager::ShutdownOnSessionThread() {
+  Finalize();
+  base::AutoLock auto_lock(lock_);
+  finalized_ = true;
+}
+
 }  // namespace midi
 }  // namespace media