Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(502)

Issue 1315793002: Revert of Take care of a FIXME in SecurityOrigin.cpp to check the validity (Closed)

Created:
5 years, 4 months ago by dstockwell
Modified:
5 years, 4 months ago
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Revert of Take care of a FIXME in SecurityOrigin.cpp to check the validity of any innerURL during constructio… (patchset #4 id:60001 of https://codereview.chromium.org/1294933004/ ) Reason for revert: Speculative revert for "Too many opened files in the system". Original issue's description: > Take care of a FIXME in SecurityOrigin.cpp to check the validity of any innerURL during construction and to handle invalidity as a 'unique' origin. > > TBR=mkwst > BUG=514076 > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201022 TBR=jsbell@chromium.org,palmer@chromium.org,mkwst@chromium.org,brettw@chromium.org,michaeln@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=514076, 524248 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201100

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -43 lines) Patch
M Source/platform/weborigin/SecurityOrigin.cpp View 1 chunk +5 lines, -10 lines 0 comments Download
M Source/platform/weborigin/SecurityOriginTest.cpp View 2 chunks +0 lines, -33 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
dstockwell
Created Revert of Take care of a FIXME in SecurityOrigin.cpp to check the validity of ...
5 years, 4 months ago (2015-08-25 04:09:43 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1315793002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1315793002/1
5 years, 4 months ago (2015-08-25 04:11:23 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://src.chromium.org/viewvc/blink?view=rev&revision=201100
5 years, 4 months ago (2015-08-25 04:11:51 UTC) #4
dstockwell
5 years, 4 months ago (2015-08-25 04:53:04 UTC) #5
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1309333004/ by dstockwell@chromium.org.

The reason for reverting is: Failure still present..

Powered by Google App Engine
This is Rietveld 408576698