Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(72)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1315783003: Make classes and structures in core/frame fast-allocated. (Closed)

Created:
5 years, 3 months ago by tasak
Modified:
5 years, 3 months ago
Reviewers:
haraken
CC:
blink-reviews, mkwst+watchlist-csp_chromium.org, blink-reviews-style_chromium.org, mlamouri+watch-blink_chromium.org, timvolodine, mvanouwerkerk+watch_chromium.org, Inactive
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Make classes and structures in core/frame fast-allocated. Added STATIC_ONLY, STACK_ALLOCATED, DISALLOW_ALLOCATION, or ALLOW_ONLY_INLINE_ALLOCATION instead of WTF_MAKE_FAST_ALLOCATED(_WILL_BE_REMOVED) if possible. BUG=523249 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201205

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -0 lines) Patch
M Source/core/frame/DeprecatedScheduleStyleRecalcDuringLayout.h View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/frame/DeviceSingleWindowEventController.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/frame/EventHandlerRegistry.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/frame/FrameClient.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/frame/FrameConsole.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/frame/FrameView.h View 1 2 chunks +2 lines, -0 lines 0 comments Download
M Source/core/frame/LayoutSubtreeRootList.h View 2 chunks +2 lines, -0 lines 0 comments Download
M Source/core/frame/OriginsUsingFeatures.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/frame/PageScaleConstraints.h View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/frame/PageScaleConstraintsSet.h View 2 chunks +2 lines, -0 lines 0 comments Download
M Source/core/frame/RootFrameViewport.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/frame/SubresourceIntegrity.h View 2 chunks +2 lines, -0 lines 0 comments Download
M Source/core/frame/TopControls.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/frame/UseCounter.h View 2 chunks +2 lines, -0 lines 0 comments Download
M Source/core/frame/csp/CSPSource.h View 2 chunks +2 lines, -0 lines 0 comments Download
M Source/core/frame/csp/CSPSourceList.h View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
tasak
Would you review this CL?
5 years, 3 months ago (2015-08-25 09:23:49 UTC) #2
haraken
LGTM https://codereview.chromium.org/1315783003/diff/1/Source/core/frame/FrameClient.h File Source/core/frame/FrameClient.h (right): https://codereview.chromium.org/1315783003/diff/1/Source/core/frame/FrameClient.h#newcode20 Source/core/frame/FrameClient.h:20: WTF_MAKE_FAST_ALLOCATED(FrameClient); This was moved to the heap by ...
5 years, 3 months ago (2015-08-25 09:33:02 UTC) #3
tasak
https://codereview.chromium.org/1315783003/diff/1/Source/core/frame/FrameClient.h File Source/core/frame/FrameClient.h (right): https://codereview.chromium.org/1315783003/diff/1/Source/core/frame/FrameClient.h#newcode20 Source/core/frame/FrameClient.h:20: WTF_MAKE_FAST_ALLOCATED(FrameClient); On 2015/08/25 09:33:02, haraken wrote: > > This ...
5 years, 3 months ago (2015-08-26 04:15:02 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1315783003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1315783003/20001
5 years, 3 months ago (2015-08-26 04:15:24 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/95663)
5 years, 3 months ago (2015-08-26 05:41:25 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1315783003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1315783003/20001
5 years, 3 months ago (2015-08-26 06:05:33 UTC) #11
commit-bot: I haz the power
5 years, 3 months ago (2015-08-26 06:41:14 UTC) #12
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=201205

Powered by Google App Engine
This is Rietveld 408576698