Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(179)

Issue 1315773005: Initialize subrun variables to make Valgrind happy (Closed)

Created:
5 years, 3 months ago by jvanverth1
Modified:
5 years, 3 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Initialize subrun variables to make Valgrind happy The check at line 1259 was failing in Valgrind, and in the default constructor subrun.fMaskFormat is never inited. Also set some other variables to avoid future problems. Committed: https://skia.googlesource.com/skia/+/ce79a3a7440b881fdb9a3d0278815b8c45c32b28

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M src/gpu/GrAtlasTextBlob.h View 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 10 (4 generated)
jvanverth1
5 years, 3 months ago (2015-09-09 21:39:06 UTC) #2
robertphillips
lgtm
5 years, 3 months ago (2015-09-09 21:40:34 UTC) #4
jvanverth1
On 2015/09/09 21:40:34, robertphillips wrote: > lgtm Still would like joshualitt@ to take a look.
5 years, 3 months ago (2015-09-10 12:38:53 UTC) #6
joshualitt
On 2015/09/10 12:38:53, jvanverth1 wrote: > On 2015/09/09 21:40:34, robertphillips wrote: > > lgtm > ...
5 years, 3 months ago (2015-09-10 13:25:00 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1315773005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1315773005/1
5 years, 3 months ago (2015-09-10 13:26:11 UTC) #9
commit-bot: I haz the power
5 years, 3 months ago (2015-09-10 13:31:43 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/ce79a3a7440b881fdb9a3d0278815b8c45c32b28

Powered by Google App Engine
This is Rietveld 408576698