Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(156)

Issue 1315773003: Revert of Fix typo in install-sysroot.py (Closed)

Created:
5 years, 3 months ago by chrishtr
Modified:
5 years, 3 months ago
Reviewers:
Dirk Pranke, Sam Clegg
CC:
chromium-reviews, Lei Zhang
Base URL:
https://chromium.googlesource.com/chromium/src.git@cleanup_sysroot_settings
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Fix typo in install-sysroot.py (patchset #2 id:20001 of https://codereview.chromium.org/1317973005/ ) Reason for revert: Caused check_licenses to fail: https://build.chromium.org/p/chromium/builders/Linux/builds/66701 Original issue's description: > Fix typo in install-sysroot.py > > install-sysroot.py was intended to default to installing > the sysroot ia32, but within this script 'i386' is used to > refer to this architecture. > > This most likely went unnoticed since the ia32 builder > either use branding=Official, or explicitly set > use_sysroot=1, or have a complete set of packages for > cross building on the host system. > > BUG=504446 > > Committed: https://crrev.com/1d62049b4c176fbd43bed90fc9a76273b11ad406 > Cr-Commit-Position: refs/heads/master@{#347821} TBR=dpranke@chromium.org,sbc@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=504446 Committed: https://crrev.com/3b27a2de111759359162bcad49753e17ee1cf002 Cr-Commit-Position: refs/heads/master@{#347839}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M build/linux/sysroot_scripts/install-sysroot.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
chrishtr
Created Revert of Fix typo in install-sysroot.py
5 years, 3 months ago (2015-09-08 23:57:39 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1315773003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1315773003/1
5 years, 3 months ago (2015-09-08 23:58:00 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-08 23:58:36 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/3b27a2de111759359162bcad49753e17ee1cf002 Cr-Commit-Position: refs/heads/master@{#347839}
5 years, 3 months ago (2015-09-08 23:59:17 UTC) #4
Dirk Pranke
lgtm
5 years, 3 months ago (2015-09-09 00:01:15 UTC) #5
Adrian Kuegel
5 years, 3 months ago (2015-09-09 10:27:37 UTC) #6
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1324853005/ by akuegel@chromium.org.

The reason for reverting is: The check_licenses script has been fixed, and it
cycled green:
https://build.chromium.org/p/chromium/builders/Linux/builds/66708.

Powered by Google App Engine
This is Rietveld 408576698