Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(246)

Issue 1315753010: adb_wait_for_device: Skip `adb wait-for-device` (Closed)

Created:
5 years, 3 months ago by borenet
Modified:
5 years, 3 months ago
Reviewers:
djsollen
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

adb_wait_for_device: Skip `adb wait-for-device` This should still wait for the device to be attached and finished booting, but will prevent no-output timeouts due to `adb wait-for-device` never finishing. The effect should be that, when an Android device is disconnected, the "wait for device" step will run forever, or until the device reconnects. This should prevent a disconnected device from spreading purple all over the status page. BUG=skia: Committed: https://skia.googlesource.com/skia/+/ad54ffc235ea02438a8510feccba9657033b5ec5

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -2 lines) Patch
M platform_tools/android/bin/adb_wait_for_device View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
borenet
5 years, 3 months ago (2015-09-03 17:04:43 UTC) #2
djsollen
how will this prevent no output timeouts? Does the shell commmand just keep returning an ...
5 years, 3 months ago (2015-09-03 17:15:51 UTC) #3
borenet
On 2015/09/03 17:15:51, djsollen wrote: > how will this prevent no output timeouts? Does the ...
5 years, 3 months ago (2015-09-03 17:16:37 UTC) #4
djsollen
lgtm
5 years, 3 months ago (2015-09-03 17:35:53 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1315753010/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1315753010/1
5 years, 3 months ago (2015-09-03 17:36:19 UTC) #7
commit-bot: I haz the power
5 years, 3 months ago (2015-09-03 17:41:10 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/ad54ffc235ea02438a8510feccba9657033b5ec5

Powered by Google App Engine
This is Rietveld 408576698