Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(84)

Issue 1315753009: CMake builds on Ubuntu now too. (Closed)

Created:
5 years, 3 months ago by mtklein_C
Modified:
5 years, 3 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

CMake builds on Ubuntu now too. Punted for now on GL on Linux. Man that's a beast. BUG=skia:4269 Committed: https://skia.googlesource.com/skia/+/2409abb812aa1c26f89604382f0653f948aebfa8

Patch Set 1 #

Patch Set 2 : working on mac too #

Patch Set 3 : ARGV -> ARGN #

Unified diffs Side-by-side diffs Delta from patch set Stats (+99 lines, -46 lines) Patch
M cmake/.gitignore View 1 chunk +1 line, -1 line 0 comments Download
M cmake/CMakeLists.txt View 1 2 8 chunks +87 lines, -40 lines 0 comments Download
M cmake/example.cpp View 3 chunks +11 lines, -5 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
mtklein_C
5 years, 3 months ago (2015-08-28 22:55:25 UTC) #2
bsalomon
On 2015/08/28 22:55:25, mtklein_C wrote: lgtm. Curious is it Skia or the OS that made ...
5 years, 3 months ago (2015-08-31 13:50:17 UTC) #3
mtklein
On 2015/08/31 13:50:17, bsalomon wrote: > On 2015/08/28 22:55:25, mtklein_C wrote: > > lgtm. Curious ...
5 years, 3 months ago (2015-08-31 13:51:48 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1315753009/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1315753009/40001
5 years, 3 months ago (2015-08-31 13:54:06 UTC) #7
commit-bot: I haz the power
5 years, 3 months ago (2015-08-31 13:59:24 UTC) #8
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/2409abb812aa1c26f89604382f0653f948aebfa8

Powered by Google App Engine
This is Rietveld 408576698