Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(171)

Issue 1315753002: Export UnmodifiableMapView from the Dart core libraries. (Closed)

Created:
5 years, 4 months ago by nweiz
Modified:
5 years, 4 months ago
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/collection@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Export UnmodifiableMapView from the Dart core libraries. Exporting this avoids collision errors when import both dart:collection and package:collection. R=lrn@google.com Committed: https://github.com/dart-lang/collection/commit/ee7709bb122e9a7c207bd0f0a046a66d826c146b

Patch Set 1 #

Total comments: 2

Patch Set 2 : Code review changes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -18 lines) Patch
M CHANGELOG.md View 1 chunk +4 lines, -0 lines 0 comments Download
M lib/src/unmodifiable_wrappers.dart View 1 2 chunks +7 lines, -15 lines 0 comments Download
M lib/wrappers.dart View 1 chunk +1 line, -3 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
nweiz
5 years, 4 months ago (2015-08-25 00:59:25 UTC) #2
Lasse Reichstein Nielsen
lgtm https://codereview.chromium.org/1315753002/diff/1/lib/src/unmodifiable_wrappers.dart File lib/src/unmodifiable_wrappers.dart (right): https://codereview.chromium.org/1315753002/diff/1/lib/src/unmodifiable_wrappers.dart#newcode14 lib/src/unmodifiable_wrappers.dart:14: library dart.pkg.collection.unmodifiable_wrappers; Feel free to change the name ...
5 years, 4 months ago (2015-08-25 07:43:48 UTC) #3
nweiz
Code review changes
5 years, 4 months ago (2015-08-25 19:45:44 UTC) #4
nweiz
https://codereview.chromium.org/1315753002/diff/1/lib/src/unmodifiable_wrappers.dart File lib/src/unmodifiable_wrappers.dart (right): https://codereview.chromium.org/1315753002/diff/1/lib/src/unmodifiable_wrappers.dart#newcode14 lib/src/unmodifiable_wrappers.dart:14: library dart.pkg.collection.unmodifiable_wrappers; On 2015/08/25 07:43:48, Lasse Reichstein Nielsen wrote: ...
5 years, 4 months ago (2015-08-25 19:45:54 UTC) #5
nweiz
Committed patchset #2 (id:20001) manually as ee7709bb122e9a7c207bd0f0a046a66d826c146b (presubmit successful).
5 years, 4 months ago (2015-08-25 19:46:18 UTC) #6
kevmoo
5 years, 4 months ago (2015-08-25 21:35:07 UTC) #8
Message was sent while issue was closed.
DBQ: isn't this a possible breaking change?

One could be assuming this is a DelecatingMap or similar

Just checking...

Powered by Google App Engine
This is Rietveld 408576698