build/android/pylib/utils/emulator.py - Issue 1315743004: [Android] Add a custom pylintrc for build/android/.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/android/pylib/utils/emulator.py

Issue 1315743004: [Android] Add a custom pylintrc for build/android/. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« build/android/pylib/instrumentation/json_perf_parser.py ('K') | « build/android/pylib/uirobot/uirobot_test_instance.py ('k') | build/android/pylib/utils/findbugs.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: build/android/pylib/utils/emulator.py

diff --git a/build/android/pylib/utils/emulator.py b/build/android/pylib/utils/emulator.py

index 162bcb8aaa1b8db873fc3da8ad7c56c78db41110..5da578730cca227f06e962f024aa8d836f37f0f1 100644

--- a/build/android/pylib/utils/emulator.py

+++ b/build/android/pylib/utils/emulator.py

@@ -22,9 +22,6 @@ from pylib import constants

from pylib import pexpect

from pylib.utils import time_profile

-import errors

-import run_command

# SD card size

SDCARD_SIZE = '512M'

@@ -116,7 +113,7 @@ def DeleteAllTempAVDs():

if 'run_tests_avd' in avd_name:

cmd = ['android', '-s', 'delete', 'avd', '--name', avd_name]

cmd_helper.RunCmd(cmd)

- logging.info('Delete AVD %s' % avd_name)

+ logging.info('Delete AVD %s', avd_name)

class PortPool(object):

@@ -432,6 +429,7 @@ class Emulator(object):

self.popen.kill()

self.popen = None

+ # pylint: disable=unused-argument

def _ShutdownOnSignal(self, _signum, _frame):

logging.critical('emulator _ShutdownOnSignal')

for sig in self._SIGNALS: