[Android] Add a custom pylintrc for build/android/.

build/android/provision_devices.py

 #!/usr/bin/env python
 #
 # Copyright (c) 2013 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """Provisions Android devices with settings required for bots.
 
 Usage:
   ./provision_devices.py [-d <device serial number>]
@@ skipping 63 matching lines @@
     with open(args.output_device_blacklist, 'w') as f:
       json.dump(blacklisted_devices, f)
   if all(d in blacklisted_devices for d in devices):
     raise device_errors.NoDevicesError
   return 0
 
 
 def ProvisionDevice(device, blacklist, options):
   if options.reboot_timeout:
     reboot_timeout = options.reboot_timeout
-  elif (device.build_version_sdk >= version_codes.LOLLIPOP):
+  elif device.build_version_sdk >= version_codes.LOLLIPOP:
     reboot_timeout = _DEFAULT_TIMEOUTS.LOLLIPOP
   else:
     reboot_timeout = _DEFAULT_TIMEOUTS.PRE_LOLLIPOP
 
   def should_run_phase(phase_name):
     return not options.phases or phase_name in options.phases
 
   def run_phase(phase_func, reboot=True):
     try:
       device.WaitUntilFullyBooted(timeout=reboot_timeout, retries=0)
@@ skipping 93 matching lines @@
     device.adb.WaitForDevice()
 
     if device_authorized:
       adb_keys_set = set(adb_keys)
       for adb_key_file in options.adb_key_files or []:
         try:
           with open(adb_key_file, 'r') as f:
             adb_public_keys = f.readlines()
           adb_keys_set.update(adb_public_keys)
         except IOError:
-          logging.warning('Unable to find adb keys file %s.' % adb_key_file)
+          logging.warning('Unable to find adb keys file %s.', adb_key_file)
       _WriteAdbKeysFile(device, '\n'.join(adb_keys_set))
   except device_errors.CommandFailedError:
     logging.exception('Possible failure while wiping the device. '
                       'Attempting to continue.')
 
 
 def _WriteAdbKeysFile(device, adb_keys_string):
   dir_path = posixpath.dirname(constants.ADB_KEYS_FILE)
   device.RunShellCommand(['mkdir', '-p', dir_path],
                          as_root=True, check_return=True)
@@ skipping 83 matching lines @@
       logging.exception('Unable to charge device to specified level.')
 
   if options.max_battery_temp is not None:
     try:
       battery = battery_utils.BatteryUtils(device)
       battery.LetBatteryCoolToTemperature(options.max_battery_temp)
     except device_errors.CommandFailedError:
       logging.exception('Unable to let battery cool to specified temperature.')
 
   def _set_and_verify_date():
-    if (device.build_version_sdk >= version_codes.MARSHMALLOW):
+    if device.build_version_sdk >= version_codes.MARSHMALLOW:
       date_format = '%m%d%H%M%Y.%S'
       set_date_command = ['date']
     else:
       date_format = '%Y%m%d.%H%M%S'
       set_date_command = ['date', '-s']
     strgmtime = time.strftime(date_format, time.gmtime())
     set_date_command.append(strgmtime)
     device.RunShellCommand(set_date_command, as_root=True, check_return=True)
 
     device_time = device.RunShellCommand(
         ['date', '+"%Y%m%d.%H%M%S"'], as_root=True,
         single_line=True).replace('"', '')
     device_time = datetime.datetime.strptime(device_time, "%Y%m%d.%H%M%S")
     correct_time = datetime.datetime.strptime(strgmtime, date_format)
     tdelta = (correct_time - device_time).seconds
     if tdelta <= 1:
       logging.info('Date/time successfully set on %s', device)
       return True
     else:
       return False
 
   # Sometimes the date is not set correctly on the devices. Retry on failure.
   if not timeout_retry.WaitFor(_set_and_verify_date, wait_period=1,
                                max_tries=2):
     raise device_errors.CommandFailedError(
         'Failed to set date & time.', device_serial=str(device))
 
   props = device.RunShellCommand('getprop', check_return=True)
   for prop in props:
-    logging.info('  %s' % prop)
+    logging.info('  %s', prop)
   if options.auto_reconnect:
     _PushAndLaunchAdbReboot(device, options.target)
 
 
 def _WipeUnderDirIfMatch(device, path, pattern, app_to_keep=None):
   ls_result = device.Ls(path)
   for (content, _) in ls_result:
     if pattern.match(content):
       if content != app_to_keep:
         _WipeFileOrDir(device, path + content)
 
 
 def _WipeFileOrDir(device, path):
   if device.PathExists(path):
     device.RunShellCommand(['rm', '-rf', path], check_return=True)
 
 
 def _PushAndLaunchAdbReboot(device, target):
   """Pushes and launches the adb_reboot binary on the device.
 
   Arguments:
     device: The DeviceUtils instance for the device to which the adb_reboot
             binary should be pushed.
     target: The build target (example, Debug or Release) which helps in
             locating the adb_reboot binary.
   """
-  logging.info('Will push and launch adb_reboot on %s' % str(device))
+  logging.info('Will push and launch adb_reboot on %s', str(device))
   # Kill if adb_reboot is already running.
   device.KillAll('adb_reboot', blocking=True, timeout=2, quiet=True)
   # Push adb_reboot
   logging.info('  Pushing adb_reboot ...')
   adb_reboot = os.path.join(constants.DIR_SOURCE_ROOT,
                             'out/%s/adb_reboot' % target)
   device.PushChangedFiles([(adb_reboot, '/data/local/tmp/')])
   # Launch adb_reboot
   logging.info('  Launching adb_reboot ...')
   device.RunShellCommand(
@@ skipping 80 matching lines @@
   args = parser.parse_args()
   constants.SetBuildType(args.target)
 
   run_tests_helper.SetLogLevel(args.verbose)
 
   return ProvisionDevices(args)
 
 
 if __name__ == '__main__':
   sys.exit(main())