Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Issue 1315743003: [part 1] Make classes and structures in modules/ fast-allocated. (Closed)

Created:
5 years, 3 months ago by tasak
Modified:
5 years, 3 months ago
Reviewers:
haraken
CC:
blink-reviews, tzik, dshwang, eric.carlson_apple.com, scheib+watch_chromium.org, apavlov+blink_chromium.org, je_julie, caseq+blink_chromium.org, aboxhall, yurys+blink_chromium.org, Justin Novosad, Rik, devtools-reviews_chromium.org, philipj_slow, nhiroki, feature-media-reviews_chromium.org, dmazzoni, lushnikov+blink_chromium.org, mlamouri+watch-blink_chromium.org, pfeldman+blink_chromium.org, nektarios, sergeyv+blink_chromium.org, kinuko+fileapi, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

[part 1] Make classes and structures in modules/ fast-allocated. - Updated modules/accessiblity, app_banner, audio_output_device, bluetooth, cachestorage, canvas2d, compositorworker, crypto, encryptedmedia, fetch, and filesystem. - Added STATIC_ONLY, STACK_ALLOCATED, DISALLOW_ALLOCATION, or ALLOW_ONLY_INLINE_ALLOCATION instead of WTF_MAKE_FAST_ALLOCATED(_WILL_BE_REMOVED) if possible. BUG=523249 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201635

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+102 lines, -67 lines) Patch
M Source/modules/accessibility/AXObject.h View 2 chunks +2 lines, -0 lines 0 comments Download
M Source/modules/accessibility/testing/InternalsAccessibility.h View 1 chunk +3 lines, -0 lines 0 comments Download
M Source/modules/app_banner/AppBannerCallbacks.h View 1 chunk +3 lines, -0 lines 0 comments Download
M Source/modules/app_banner/AppBannerController.h View 2 chunks +2 lines, -5 lines 0 comments Download
M Source/modules/audio_output_devices/HTMLMediaElementAudioOutputDevice.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/modules/audio_output_devices/SetSinkIdCallbacks.h View 1 chunk +3 lines, -0 lines 0 comments Download
M Source/modules/background_sync/SyncCallbacks.h View 5 chunks +13 lines, -0 lines 0 comments Download
M Source/modules/background_sync/SyncError.h View 1 chunk +2 lines, -4 lines 0 comments Download
M Source/modules/bluetooth/BluetoothError.h View 2 chunks +2 lines, -4 lines 0 comments Download
M Source/modules/bluetooth/BluetoothSupplement.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/modules/bluetooth/ConvertWebVectorToArrayBuffer.h View 1 chunk +1 line, -4 lines 0 comments Download
M Source/modules/cachestorage/CacheStorageError.h View 2 chunks +2 lines, -1 line 0 comments Download
M Source/modules/cachestorage/GlobalCacheStorage.h View 2 chunks +3 lines, -0 lines 0 comments Download
M Source/modules/canvas2d/CanvasRenderingContext2DState.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/modules/canvas2d/ClipList.h View 2 chunks +2 lines, -0 lines 0 comments Download
M Source/modules/canvas2d/EventHitRegion.h View 2 chunks +2 lines, -0 lines 0 comments Download
M Source/modules/canvas2d/MouseEventHitRegion.h View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/modules/canvas2d/TouchHitRegion.h View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/modules/compositorworker/CompositorWorkerManager.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M Source/modules/compositorworker/CompositorWorkerMessagingProxy.h View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/modules/credentialmanager/CredentialManagerClient.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/modules/crypto/DOMWindowCrypto.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/modules/crypto/NormalizeAlgorithm.h View 2 chunks +2 lines, -0 lines 0 comments Download
M Source/modules/crypto/WorkerGlobalScopeCrypto.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/modules/encryptedmedia/EncryptedMediaUtils.h View 1 chunk +2 lines, -3 lines 0 comments Download
M Source/modules/encryptedmedia/HTMLMediaElementEncryptedMedia.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/modules/encryptedmedia/MediaKeysClient.h View 1 chunk +3 lines, -0 lines 0 comments Download
M Source/modules/encryptedmedia/MediaKeysController.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/modules/encryptedmedia/NavigatorRequestMediaKeySystemAccess.h View 1 chunk +1 line, -3 lines 0 comments Download
M Source/modules/fetch/CompositeDataConsumerHandle.h View 2 chunks +2 lines, -0 lines 0 comments Download
M Source/modules/fetch/DataConsumerHandleTestUtil.h View 11 chunks +12 lines, -0 lines 0 comments Download
M Source/modules/fetch/DataConsumerHandleUtil.h View 2 chunks +2 lines, -0 lines 0 comments Download
M Source/modules/fetch/DataConsumerTee.h View 2 chunks +2 lines, -0 lines 0 comments Download
M Source/modules/fetch/FetchDataConsumerHandle.h View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/modules/fetch/FetchManager.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/modules/fetch/FetchRequestData.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/modules/fetch/GlobalFetch.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/modules/filesystem/DOMFilePath.h View 2 chunks +2 lines, -3 lines 0 comments Download
M Source/modules/filesystem/DOMWindowFileSystem.h View 3 chunks +2 lines, -4 lines 0 comments Download
M Source/modules/filesystem/DOMWindowFileSystem.cpp View 1 chunk +0 lines, -8 lines 0 comments Download
M Source/modules/filesystem/DataTransferItemFileSystem.h View 2 chunks +2 lines, -4 lines 0 comments Download
M Source/modules/filesystem/DevToolsHostFileSystem.h View 2 chunks +2 lines, -3 lines 0 comments Download
M Source/modules/filesystem/DevToolsHostFileSystem.cpp View 1 chunk +0 lines, -5 lines 0 comments Download
M Source/modules/filesystem/FileSystemClient.h View 2 chunks +2 lines, -0 lines 0 comments Download
M Source/modules/filesystem/HTMLInputElementFileSystem.h View 2 chunks +2 lines, -4 lines 0 comments Download
M Source/modules/filesystem/HTMLInputElementFileSystem.cpp View 1 chunk +0 lines, -8 lines 0 comments Download
M Source/modules/filesystem/LocalFileSystem.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/modules/filesystem/WorkerGlobalScopeFileSystem.h View 2 chunks +1 line, -4 lines 0 comments Download
M Source/platform/AsyncFileSystemCallbacks.h View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
tasak
Would you review this CL?
5 years, 3 months ago (2015-09-01 08:20:57 UTC) #2
haraken
LGTM
5 years, 3 months ago (2015-09-01 08:42:37 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1315743003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1315743003/20001
5 years, 3 months ago (2015-09-02 08:54:47 UTC) #6
commit-bot: I haz the power
5 years, 3 months ago (2015-09-02 11:08:26 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=201635

Powered by Google App Engine
This is Rietveld 408576698