Android: moves autofill to use long for JNI.

Android: moves autofill to use long for JNI.

BUG=317523
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=244146

[bulach, 2014-01-09 11:52:48]

ptal

[Jói, 2014-01-09 11:53:57]

LGTM

On Thu, Jan 9, 2014 at 11:52 AM,  <bulach@chromium.org> wrote:
> Reviewers: Jói,
>
> Message:
> ptal
>
> Description:
> Android: moves autofill to use long for JNI.
>
> BUG=317523
>
> Please review this at https://codereview.chromium.org/131573002/
>
> SVN Base: svn://svn.chromium.org/chrome/trunk/src
>
> Affected files (+2, -1 lines):
>   M components/autofill.gypi
>
>
> Index: components/autofill.gypi
> diff --git a/components/autofill.gypi b/components/autofill.gypi
> index
>
9bbe26e9af8e8966c16d8a05b2b950fca29fd3fa..21a6491222f68ac0a3555b28dc8a143d95b3bdc5
> 100644
> --- a/components/autofill.gypi
> +++ b/components/autofill.gypi
> @@ -22,7 +22,7 @@
>
> 'autofill/core/browser/autofill_regex_constants.cc.utf8'],
>        }],
>      },
> -
> +
>      {
>        'target_name': 'autofill_core_common',
>        'type': 'static_library',
> @@ -424,6 +424,7 @@
>            ],
>            'variables': {
>              'jni_gen_package': 'autofill',
> +            'jni_generator_ptr_type': 'long',
>            },
>            'includes': [ '../build/jni_generator.gypi' ],
>          },
>
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[commit-bot: I haz the power, 2014-01-09 14:20:19]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/bulach@chromium.org/131573002/1

[commit-bot: I haz the power, 2014-01-09 14:20:22]

Failed to apply patch for components/autofill.gypi:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file components/autofill.gypi
  Hunk #1 FAILED at 22.
  Hunk #2 succeeded at 426 (offset 2 lines).
  1 out of 2 hunks FAILED -- saving rejects to file components/autofill.gypi.rej

Patch:       components/autofill.gypi
Index: components/autofill.gypi
diff --git a/components/autofill.gypi b/components/autofill.gypi
index
9bbe26e9af8e8966c16d8a05b2b950fca29fd3fa..21a6491222f68ac0a3555b28dc8a143d95b3bdc5
100644
--- a/components/autofill.gypi
+++ b/components/autofill.gypi
@@ -22,7 +22,7 @@
                    'autofill/core/browser/autofill_regex_constants.cc.utf8'],
       }],
     },
-    
+
     {
       'target_name': 'autofill_core_common',
       'type': 'static_library',
@@ -424,6 +424,7 @@
           ],
           'variables': {
             'jni_gen_package': 'autofill',
+            'jni_generator_ptr_type': 'long',
           },
           'includes': [ '../build/jni_generator.gypi' ],
         },

[commit-bot: I haz the power, 2014-01-10 09:19:39]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/bulach@chromium.org/131573002/70001

[commit-bot: I haz the power, 2014-01-10 11:13:53]

Change committed as 244146