Added browser tests for caret position and selection.

Added browser tests for caret position and selection.

BUG=491027
R=dmazzoni@chromium.org, dtseng@chromium.org

Committed: https://crrev.com/dbcb6ee8a1a359e1f33315b16a9e4934bb29f5cf
Cr-Commit-Position: refs/heads/master@{#348813}

[Peter Lundblad, 2015-08-28 15:27:49]

plundblad@chromium.org changed reviewers:
+ plundblad@chromium.org

[Peter Lundblad, 2015-08-28 15:27:50]

https://codereview.chromium.org/1315703004/diff/40001/content/browser/accessi...
File content/browser/accessibility/dump_accessibility_tree_browsertest.cc
(right):

https://codereview.chromium.org/1315703004/diff/40001/content/browser/accessi...
content/browser/accessibility/dump_accessibility_tree_browsertest.cc:1171: 
Looks like the AccessibilityTextArea test was removed. Was that intentional?

[David Tseng, 2015-08-28 16:08:47]

https://codereview.chromium.org/1315703004/diff/40001/content/browser/accessi...
File content/browser/accessibility/dump_accessibility_tree_browsertest.cc
(right):

https://codereview.chromium.org/1315703004/diff/40001/content/browser/accessi...
content/browser/accessibility/dump_accessibility_tree_browsertest.cc:488:
IN_PROC_BROWSER_TEST_F(DumpAccessibilityTreeTest, AccessibilityAriaSearchbox) {
nit: Why not camel case AccessibilityAriaSearchbox?

https://codereview.chromium.org/1315703004/diff/40001/content/browser/accessi...
content/browser/accessibility/dump_accessibility_tree_browsertest.cc:1170: 
The test for AccessibilityTextArea was removed?

https://codereview.chromium.org/1315703004/diff/40001/content/test/data/acces...
File content/test/data/accessibility/aria/aria-searchbox-with-selection.html
(right):

https://codereview.chromium.org/1315703004/diff/40001/content/test/data/acces...
content/test/data/accessibility/aria/aria-searchbox-with-selection.html:21:
selection.addRange(selectionRange);
It would be great to do this natively (using accessibilitySetTextSelection)
since it exercises a slightly different codepath.

[dmazzoni, 2015-08-28 21:48:54]

https://codereview.chromium.org/1315703004/diff/40001/content/test/data/acces...
File
content/test/data/accessibility/aria/aria-searchbox-with-selection-expected-win.txt
(right):

https://codereview.chromium.org/1315703004/diff/40001/content/test/data/acces...
content/test/data/accessibility/aria/aria-searchbox-with-selection-expected-win.txt:3:
++++ROLE_SYSTEM_STATICTEXT name='ARIA role searchbox.'
It looks like this expectation needs to be updated to include the selection?

https://codereview.chromium.org/1315703004/diff/40001/content/test/data/acces...
File content/test/data/accessibility/aria/aria-searchbox-with-selection.html
(right):

https://codereview.chromium.org/1315703004/diff/40001/content/test/data/acces...
content/test/data/accessibility/aria/aria-searchbox-with-selection.html:21:
selection.addRange(selectionRange);
On 2015/08/28 16:08:46, David Tseng wrote:
> It would be great to do this natively (using accessibilitySetTextSelection)
> since it exercises a slightly different codepath.

Maybe in a different test? That couldn't be done from a DumpAccessibilityTree
test

https://codereview.chromium.org/1315703004/diff/40001/content/test/data/acces...
File
content/test/data/accessibility/aria/aria-textbox-with-selection-expected-win.txt
(right):

https://codereview.chromium.org/1315703004/diff/40001/content/test/data/acces...
content/test/data/accessibility/aria/aria-textbox-with-selection-expected-win.txt:3:
++ROLE_SYSTEM_TEXT IA2_STATE_MULTI_LINE xml-roles:textbox
Same - I expected to see the selection here in the output

[chromium-reviews, 2015-09-03 15:30:50]

Textarea test was added back.
I updated all expectations for all tests to the correct output.
Some tests were made a bit more complex to exercise some more code 
paths. Two small bugs were uncovered this way and file against me:
A) Aria-searchbox is treated as an editable text box even when the 
content editable attribute has not been specified. Remember that ARIA 
should not change behavior.
B) A selection is reported on the ancestors of any text field, even when 
the text field has a simple caret displayed in it but no actual selection.

I opted not to change the case of AriaSearchbox because there is no dash 
in the attribute (it's "searchbox" and not "search-box"), because the 
file name which holds the test is also spelled "aria-searchbox" and not 
"aria-search-box" and for consistency reasons: textarea and AriaTextbox 
have similar casing. Either we should change all similar examples to use 
two capitals, or make AriaSearchBox consistent with the others.

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[chromium-reviews, 2015-09-03 16:15:55]

I forgot to say that the native function 
AXWebObject::setSelectedTextRange is going to be covered by a layout 
test that has already been LGTMed.

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[dmazzoni, 2015-09-10 18:48:34]

lgtm

Sorry this slipped off my radar.

[nektarios, 2015-09-14 16:20:48]

The CQ bit was checked by nektar@chromium.org

[nektarios, 2015-09-14 16:20:49]

The patchset sent to the CQ was uploaded after l-g-t-m from
dmazzoni@chromium.org
Link to the patchset: https://codereview.chromium.org/1315703004/#ps100001
(title: "Fixed test expectations for two Mac tests.")

[commit-bot: I haz the power, 2015-09-14 16:21:45]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1315703004/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1315703004/100001

[commit-bot: I haz the power, 2015-09-14 16:36:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-09-14 16:36:49]

Try jobs failed on following builders:
  linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[nektarios, 2015-09-14 17:13:55]

The CQ bit was checked by nektar@chromium.org

[commit-bot: I haz the power, 2015-09-14 17:14:52]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1315703004/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1315703004/100001

[commit-bot: I haz the power, 2015-09-14 17:57:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-09-14 17:58:00]

Try jobs failed on following builders:
  win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[nektarios, 2015-09-14 20:24:17]

The CQ bit was checked by nektar@chromium.org

[nektarios, 2015-09-14 20:24:18]

The patchset sent to the CQ was uploaded after l-g-t-m from
dmazzoni@chromium.org
Link to the patchset: https://codereview.chromium.org/1315703004/#ps120001
(title: "Fixed password masked character in test expectations.")

[commit-bot: I haz the power, 2015-09-14 20:24:47]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1315703004/120001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1315703004/120001

[commit-bot: I haz the power, 2015-09-14 23:41:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-09-14 23:41:06]

Try jobs failed on following builders:
  linux_android_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_android_r...)

[nektarios, 2015-09-15 00:20:08]

The CQ bit was checked by nektar@chromium.org

[nektarios, 2015-09-15 00:20:08]

The patchset sent to the CQ was uploaded after l-g-t-m from
dmazzoni@chromium.org
Link to the patchset: https://codereview.chromium.org/1315703004/#ps140001
(title: "Fixed Android tests.")

[commit-bot: I haz the power, 2015-09-15 00:21:29]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1315703004/140001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1315703004/140001

[commit-bot: I haz the power, 2015-09-15 01:46:29]

Committed patchset #8 (id:140001)

[commit-bot: I haz the power, 2015-09-15 01:47:26]

Patchset 8 (id:??) landed as
https://crrev.com/dbcb6ee8a1a359e1f33315b16a9e4934bb29f5cf
Cr-Commit-Position: refs/heads/master@{#348813}

[commit-bot: I haz the power, 2015-09-23 12:41:19]

Patchset 8 (id:??) landed as
https://crrev.com/dbcb6ee8a1a359e1f33315b16a9e4934bb29f5cf
Cr-Commit-Position: refs/heads/master@{#348813}