Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Unified Diff: src/profile-generator.cc

Issue 1315683007: Profiler: resolve top of stack address to a function (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/profile-generator.cc
diff --git a/src/profile-generator.cc b/src/profile-generator.cc
index 09468cad75d4860059ef1edc8dd0e96b948c7873..2ff92e0df970e41aa6766d1a37c281c8f9bf774f 100644
--- a/src/profile-generator.cc
+++ b/src/profile-generator.cc
@@ -637,6 +637,12 @@ void ProfileGenerator::RecordTickSample(const TickSample& sample) {
*entry++ = unresolved_entry_;
}
}
+ } else if (sample.top_frame_type == StackFrame::JAVA_SCRIPT ||
+ sample.top_frame_type == StackFrame::OPTIMIZED) {
+ // Find out, if top of stack was pointing inside a JS function
+ // meaning that we have encountered a frameless invocation.
+ Address start;
+ *entry++ = code_map_.FindEntry(sample.tos, &start);
alph 2015/09/10 06:20:36 You can omit the second argument.
yurys 2015/09/10 15:58:49 Done. Also I did more clean-up in another CL: http
}
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698