WebUSB bindings part 6

WebUSB bindings part 6

This connects USBDevice interface methods to the embedder.

BUG=492204
R=reillyg@chromium.org

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201107

[Ken Rockot(use gerrit already), 2015-08-24 20:20:51]

please take a look! note that this patch and the content counterpart
(https://codereview.chromium.org/1314493003/) should have no mutual
dependencies, so they can land in any order.

[Reilly Grant (use Gerrit), 2015-08-24 21:47:17]

https://codereview.chromium.org/1315683002/diff/1/Source/modules/webusb/USBDe...
File Source/modules/webusb/USBDevice.cpp (right):

https://codereview.chromium.org/1315683002/diff/1/Source/modules/webusb/USBDe...
Source/modules/webusb/USBDevice.cpp:41: return DOMException::create(AbortError,
"The control transfer requestType parameter is invalid.");
As I understand it these should be TypeErrors.

https://codereview.chromium.org/1315683002/diff/1/Source/modules/webusb/USBDe...
Source/modules/webusb/USBDevice.cpp:110: if (m_buffer.isArrayBuffer())
Handle the case of m_buffer.isNull()?

https://codereview.chromium.org/1315683002/diff/1/Source/modules/webusb/USBIn...
File Source/modules/webusb/USBInTransferResult.h (right):

https://codereview.chromium.org/1315683002/diff/1/Source/modules/webusb/USBIn...
Source/modules/webusb/USBInTransferResult.h:18: class USBInterface;
These forward declarations are unnecessary.

https://codereview.chromium.org/1315683002/diff/1/Source/modules/webusb/USBOu...
File Source/modules/webusb/USBOutTransferResult.h (right):

https://codereview.chromium.org/1315683002/diff/1/Source/modules/webusb/USBOu...
Source/modules/webusb/USBOutTransferResult.h:18: class USBInterface;
These forward declarations are unnecessary.

[Ken Rockot(use gerrit already), 2015-08-24 22:52:37]

https://codereview.chromium.org/1315683002/diff/1/Source/modules/webusb/USBDe...
File Source/modules/webusb/USBDevice.cpp (right):

https://codereview.chromium.org/1315683002/diff/1/Source/modules/webusb/USBDe...
Source/modules/webusb/USBDevice.cpp:41: return DOMException::create(AbortError,
"The control transfer requestType parameter is invalid.");
On 2015/08/24 21:47:17, Reilly Grant wrote:
> As I understand it these should be TypeErrors.

TypeMismatchError?

https://codereview.chromium.org/1315683002/diff/1/Source/modules/webusb/USBDe...
Source/modules/webusb/USBDevice.cpp:110: if (m_buffer.isArrayBuffer())
On 2015/08/24 21:47:17, Reilly Grant wrote:
> Handle the case of m_buffer.isNull()?

Added an ASSERT to the constructor. It should never be null. If you pass null to
controlTransferOut, generated code will throw an error because a null value is
invalid according to the IDL. If the optional |data| argument is omitted it will
be |undefined| rather than null, and the other controlTransfer overload (the one
which doesn't construct a BufferSource) will be called.

https://codereview.chromium.org/1315683002/diff/1/Source/modules/webusb/USBIn...
File Source/modules/webusb/USBInTransferResult.h (right):

https://codereview.chromium.org/1315683002/diff/1/Source/modules/webusb/USBIn...
Source/modules/webusb/USBInTransferResult.h:18: class USBInterface;
On 2015/08/24 21:47:17, Reilly Grant wrote:
> These forward declarations are unnecessary.

Done.

https://codereview.chromium.org/1315683002/diff/1/Source/modules/webusb/USBOu...
File Source/modules/webusb/USBOutTransferResult.h (right):

https://codereview.chromium.org/1315683002/diff/1/Source/modules/webusb/USBOu...
Source/modules/webusb/USBOutTransferResult.h:18: class USBInterface;
On 2015/08/24 21:47:17, Reilly Grant wrote:
> These forward declarations are unnecessary.

Done.

[Reilly Grant (use Gerrit), 2015-08-24 23:46:22]

lgtm once you fix the blink-gc errors.

[Ken Rockot(use gerrit already), 2015-08-25 00:56:39]

The CQ bit was checked by rockot@chromium.org

[Ken Rockot(use gerrit already), 2015-08-25 00:56:39]

The patchset sent to the CQ was uploaded after l-g-t-m from reillyg@chromium.org
Link to the patchset: https://codereview.chromium.org/1315683002/#ps60001
(title: "remote USBTransferStatus.idl")

[commit-bot: I haz the power, 2015-08-25 00:57:03]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1315683002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1315683002/60001

[commit-bot: I haz the power, 2015-08-25 01:41:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-08-25 01:41:22]

Try jobs failed on following builders:
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Ken Rockot(use gerrit already), 2015-08-25 02:12:48]

The CQ bit was checked by rockot@chromium.org

[commit-bot: I haz the power, 2015-08-25 02:13:02]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1315683002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1315683002/60001

[commit-bot: I haz the power, 2015-08-25 03:10:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-08-25 03:10:17]

Try jobs failed on following builders:
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Ken Rockot(use gerrit already), 2015-08-25 05:01:11]

The CQ bit was checked by rockot@chromium.org

[commit-bot: I haz the power, 2015-08-25 05:01:20]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1315683002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1315683002/60001

[commit-bot: I haz the power, 2015-08-25 06:14:44]

Committed patchset #4 (id:60001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=201107