Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(136)

Issue 1315643009: DevTools: Tweak timeline tree view bars (Closed)

Created:
5 years, 3 months ago by alph
Modified:
5 years, 3 months ago
Reviewers:
paulirish, pfeldman
CC:
apavlov+blink_chromium.org, blink-reviews, caseq+blink_chromium.org, devtools-reviews_chromium.org, kozyatinskiy+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, sergeyv+blink_chromium.org, yurys+blink_chromium.org
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

DevTools: Tweak timeline tree view bars BUG=529956 R=pfeldman Committed: https://crrev.com/743a4af8dc48b507105fc6387c6071703d8734bc git-svn-id: svn://svn.chromium.org/blink/trunk@202017 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -7 lines) Patch
M Source/devtools/front_end/timeline/TimelineTreeView.js View 1 chunk +2 lines, -1 line 0 comments Download
M Source/devtools/front_end/timeline/timelinePanel.css View 1 chunk +10 lines, -6 lines 2 comments Download

Messages

Total messages: 9 (2 generated)
alph
5 years, 3 months ago (2015-09-09 23:00:29 UTC) #1
pfeldman
lgtm
5 years, 3 months ago (2015-09-09 23:53:49 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1315643009/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1315643009/1
5 years, 3 months ago (2015-09-10 00:06:06 UTC) #4
paulirish
"Small bars are not shown." What is this comment about? https://codereview.chromium.org/1315643009/diff/1/Source/devtools/front_end/timeline/timelinePanel.css File Source/devtools/front_end/timeline/timelinePanel.css (right): https://codereview.chromium.org/1315643009/diff/1/Source/devtools/front_end/timeline/timelinePanel.css#newcode1049 ...
5 years, 3 months ago (2015-09-10 00:11:43 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://src.chromium.org/viewvc/blink?view=rev&revision=202017
5 years, 3 months ago (2015-09-10 01:34:52 UTC) #7
alph
https://codereview.chromium.org/1315643009/diff/1/Source/devtools/front_end/timeline/timelinePanel.css File Source/devtools/front_end/timeline/timelinePanel.css (right): https://codereview.chromium.org/1315643009/diff/1/Source/devtools/front_end/timeline/timelinePanel.css#newcode1049 Source/devtools/front_end/timeline/timelinePanel.css:1049: float: right; On 2015/09/10 00:11:43, paulirish wrote: > The ...
5 years, 3 months ago (2015-09-10 17:37:09 UTC) #8
commit-bot: I haz the power
5 years, 3 months ago (2015-09-23 12:06:11 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/743a4af8dc48b507105fc6387c6071703d8734bc

Powered by Google App Engine
This is Rietveld 408576698