Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(287)

Side by Side Diff: Source/devtools/front_end/security/SecurityPanel.js

Issue 1315643008: Security panel: observe targets before adding listeners. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 /** 5 /**
6 * @constructor 6 * @constructor
7 * @extends {WebInspector.PanelWithSidebar} 7 * @extends {WebInspector.PanelWithSidebar}
8 * @implements {WebInspector.TargetManager.Observer} 8 * @implements {WebInspector.TargetManager.Observer}
9 */ 9 */
10 WebInspector.SecurityPanel = function() 10 WebInspector.SecurityPanel = function()
(...skipping 16 matching lines...) Expand all
27 this._sidebarOriginSection = new WebInspector.SidebarSectionTreeElement(WebI nspector.UIString("Origins")); 27 this._sidebarOriginSection = new WebInspector.SidebarSectionTreeElement(WebI nspector.UIString("Origins"));
28 this._sidebarOriginSection.listItemElement.classList.add("security-sidebar-o rigins"); 28 this._sidebarOriginSection.listItemElement.classList.add("security-sidebar-o rigins");
29 sidebarTree.appendChild(this._sidebarOriginSection); 29 sidebarTree.appendChild(this._sidebarOriginSection);
30 30
31 this._mainView = new WebInspector.SecurityMainView(); 31 this._mainView = new WebInspector.SecurityMainView();
32 32
33 /** @type {!Map<!WebInspector.SecurityPanel.Origin, !WebInspector.SecurityPa nel.OriginState>} */ 33 /** @type {!Map<!WebInspector.SecurityPanel.Origin, !WebInspector.SecurityPa nel.OriginState>} */
34 this._origins = new Map(); 34 this._origins = new Map();
35 // TODO(lgarron): add event listeners to call _clear() once we figure out ho w to clear the panel properly (https://crbug.com/522762). 35 // TODO(lgarron): add event listeners to call _clear() once we figure out ho w to clear the panel properly (https://crbug.com/522762).
36 36
37 WebInspector.targetManager.observeTargets(this);
38
37 WebInspector.targetManager.addModelListener(WebInspector.NetworkManager, Web Inspector.NetworkManager.EventTypes.ResponseReceivedSecurityDetails, this._onRes ponseReceivedSecurityDetails, this); 39 WebInspector.targetManager.addModelListener(WebInspector.NetworkManager, Web Inspector.NetworkManager.EventTypes.ResponseReceivedSecurityDetails, this._onRes ponseReceivedSecurityDetails, this);
38 WebInspector.targetManager.addModelListener(WebInspector.SecurityModel, WebI nspector.SecurityModel.EventTypes.SecurityStateChanged, this._onSecurityStateCha nged, this); 40 WebInspector.targetManager.addModelListener(WebInspector.SecurityModel, WebI nspector.SecurityModel.EventTypes.SecurityStateChanged, this._onSecurityStateCha nged, this);
39
40 WebInspector.targetManager.observeTargets(this);
41 } 41 }
42 42
43 /** @typedef {string} */ 43 /** @typedef {string} */
44 WebInspector.SecurityPanel.Origin; 44 WebInspector.SecurityPanel.Origin;
45 45
46 /** 46 /**
47 * @typedef {Object} 47 * @typedef {Object}
48 * @property {!SecurityAgent.SecurityState} securityState - Current security sta te of the origin. 48 * @property {!SecurityAgent.SecurityState} securityState - Current security sta te of the origin.
49 * @property {?NetworkAgent.SecurityDetails} securityDetails - Security details of the origin, if available. 49 * @property {?NetworkAgent.SecurityDetails} securityDetails - Security details of the origin, if available.
50 * @property {?NetworkAgent.CertificateDetails} securityDetails.certificateDetai ls - Certificate details of the origin (attached to security details), if availa ble. 50 * @property {?NetworkAgent.CertificateDetails} securityDetails.certificateDetai ls - Certificate details of the origin (attached to security details), if availa ble.
(...skipping 496 matching lines...) Expand 10 before | Expand all | Expand 10 after
547 547
548 var valueDiv = row.createChild("div"); 548 var valueDiv = row.createChild("div");
549 if (value instanceof HTMLDivElement) { 549 if (value instanceof HTMLDivElement) {
550 valueDiv.appendChild(value); 550 valueDiv.appendChild(value);
551 } else { 551 } else {
552 valueDiv.textContent = value; 552 valueDiv.textContent = value;
553 } 553 }
554 } 554 }
555 } 555 }
556 556
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698