chrome/browser/extensions/api/web_request/web_request_api_unittest.cc - Issue 1315643005: Use EnumerateHeaderLines to parse added headers in webRequest API

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/web_request/web_request_api_unittest.cc

Issue 1315643005: Use EnumerateHeaderLines to parse added headers in webRequest API (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | extensions/browser/api/web_request/web_request_api_helpers.cc » ('j') | extensions/browser/api/web_request/web_request_api_helpers.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/web_request/web_request_api_unittest.cc

diff --git a/chrome/browser/extensions/api/web_request/web_request_api_unittest.cc b/chrome/browser/extensions/api/web_request/web_request_api_unittest.cc

index 5cfdd3b8fe9d97bd5bf7b3e7d8e8dfb606829234..818da9cf26f23a87aa36acfb081233be1b05f50c 100644

--- a/chrome/browser/extensions/api/web_request/web_request_api_unittest.cc

+++ b/chrome/browser/extensions/api/web_request/web_request_api_unittest.cc

@@ -1287,6 +1287,7 @@ TEST(ExtensionWebRequestHelpersTest, TestCalculateOnHeadersReceivedDelta) {

"Key1: Value1\r\n"

"Key2: Value2, Bar\r\n"

"Key3: Value3\r\n"

+ "Key5: Value5, end5\r\n"

"\r\n";

scoped_refptr<net::HttpResponseHeaders> base_headers(

new net::HttpResponseHeaders(

@@ -1298,6 +1299,7 @@ TEST(ExtensionWebRequestHelpersTest, TestCalculateOnHeadersReceivedDelta) {

new_headers.push_back(ResponseHeader("Key2", "Value1")); // Modified

// Key3 is deleted

new_headers.push_back(ResponseHeader("Key4", "Value4")); // Added

+ new_headers.push_back(ResponseHeader("Key5", "Value5, end5")); // Unchanged

GURL effective_new_url;

scoped_ptr<EventResponseDelta> delta(