Quick Fix to the toBlob mime type Layout Test that crash the memorysanitizer.

Quick Fix to the toBlob mime type Layout Test that crash the memorysanitizer.



BUG=525824
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201408

[xlai (Olivia), 2015-08-28 01:07:50]

Patchset #3 (id:40001) has been deleted

[xlai (Olivia), 2015-08-28 01:07:59]

Patchset #2 (id:20001) has been deleted

[xlai (Olivia), 2015-08-28 01:51:29]

The CQ bit was checked by xlai@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-08-28 01:51:42]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1315633004/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1315633004/60001

[commit-bot: I haz the power, 2015-08-28 01:51:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-08-28 01:51:44]

Dry run: No L-G-T-M from a valid reviewer yet. Only full committers are
accepted.
Even if an L-G-T-M may have been provided, it was from a non-committer,
_not_ a full super star committer.
See http://www.chromium.org/getting-involved/become-a-committer
Note that this has nothing to do with OWNERS files.

[xlai (Olivia), 2015-08-28 02:05:22]

xlai@chromium.org changed reviewers:
+ senorblanco@chromium.org

[xlai (Olivia), 2015-08-28 02:27:30]

This is a quick fix for the error produced on Build Server WebKit Linux MSAN.
There is a crash because of memory sanitizer due to the uninitialized quality
pointer.

Previously, the CQ dry run does not run on WebKit Linux MSAN at all and
therefore the error was not detected at the time I committed.

[Stephen White, 2015-08-28 11:43:36]

https://codereview.chromium.org/1315633004/diff/60001/Source/core/html/HTMLCa...
File Source/core/html/HTMLCanvasElement.cpp (right):

https://codereview.chromium.org/1315633004/diff/60001/Source/core/html/HTMLCa...
Source/core/html/HTMLCanvasElement.cpp:558: double* qualityPtr = nullptr;
Perhaps I'm misunderstanding, but would simply initializing quality to 0 work?

[Stephen White, 2015-08-28 11:50:09]

On 2015/08/28 11:43:36, Stephen White wrote:
>
https://codereview.chromium.org/1315633004/diff/60001/Source/core/html/HTMLCa...
> File Source/core/html/HTMLCanvasElement.cpp (right):
> 
>
https://codereview.chromium.org/1315633004/diff/60001/Source/core/html/HTMLCa...
> Source/core/html/HTMLCanvasElement.cpp:558: double* qualityPtr = nullptr;
> Perhaps I'm misunderstanding, but would simply initializing quality to 0 work?

Never mind; I see now you probably want the default compression quality in the
case where it isn't specified.

LGTM

[xlai (Olivia), 2015-08-28 14:49:51]

The CQ bit was checked by xlai@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-08-28 14:50:01]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1315633004/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1315633004/80001

[commit-bot: I haz the power, 2015-08-28 15:54:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-08-28 15:54:12]

Dry run: This issue passed the CQ dry run.

[xlai (Olivia), 2015-08-28 16:09:45]

The CQ bit was checked by xlai@chromium.org

[xlai (Olivia), 2015-08-28 16:09:45]

The patchset sent to the CQ was uploaded after l-g-t-m from
senorblanco@chromium.org
Link to the patchset: https://codereview.chromium.org/1315633004/#ps80001
(title: "removed crash flag")

[commit-bot: I haz the power, 2015-08-28 16:09:51]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1315633004/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1315633004/80001

[commit-bot: I haz the power, 2015-08-28 16:14:13]

Committed patchset #3 (id:80001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=201408