Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(492)

Issue 1315603002: [Android] Add DeviceUtils.GetApplicationVersion (Closed)

Created:
5 years, 4 months ago by perezju
Modified:
5 years, 3 months ago
Reviewers:
jbudorick
CC:
chromium-reviews, jbudorick+watch_chromium.org, klundberg+watch_chromium.org, yfriedman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Android] Add DeviceUtils.GetApplicationVersion Provide a method to get the version name of a package installed on a device. BUG= Committed: https://crrev.com/8f88a850e01a8cc6706ac39f4f5dfa87f6f376b3 Cr-Commit-Position: refs/heads/master@{#345827}

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -0 lines) Patch
M build/android/pylib/device/device_utils.py View 1 chunk +22 lines, -0 lines 3 comments Download
M build/android/pylib/device/device_utils_test.py View 1 chunk +30 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (4 generated)
perezju
Please have a look.
5 years, 4 months ago (2015-08-24 16:39:13 UTC) #2
perezju
ping
5 years, 3 months ago (2015-08-26 09:25:38 UTC) #3
jbudorick
https://codereview.chromium.org/1315603002/diff/1/build/android/pylib/device/device_utils.py File build/android/pylib/device/device_utils.py (right): https://codereview.chromium.org/1315603002/diff/1/build/android/pylib/device/device_utils.py#newcode402 build/android/pylib/device/device_utils.py:402: return None Should this be an exception, too?
5 years, 3 months ago (2015-08-26 13:01:18 UTC) #4
perezju
https://codereview.chromium.org/1315603002/diff/1/build/android/pylib/device/device_utils.py File build/android/pylib/device/device_utils.py (right): https://codereview.chromium.org/1315603002/diff/1/build/android/pylib/device/device_utils.py#newcode402 build/android/pylib/device/device_utils.py:402: return None On 2015/08/26 at 13:01:18, jbudorick wrote: > ...
5 years, 3 months ago (2015-08-26 13:21:12 UTC) #5
jbudorick
lgtm https://codereview.chromium.org/1315603002/diff/1/build/android/pylib/device/device_utils.py File build/android/pylib/device/device_utils.py (right): https://codereview.chromium.org/1315603002/diff/1/build/android/pylib/device/device_utils.py#newcode402 build/android/pylib/device/device_utils.py:402: return None On 2015/08/26 at 13:21:12, perezju wrote: ...
5 years, 3 months ago (2015-08-26 13:22:51 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1315603002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1315603002/1
5 years, 3 months ago (2015-08-26 13:35:50 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/103762)
5 years, 3 months ago (2015-08-26 17:06:38 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1315603002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1315603002/1
5 years, 3 months ago (2015-08-27 08:48:10 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-08-27 09:24:26 UTC) #13
commit-bot: I haz the power
5 years, 3 months ago (2015-08-27 09:25:15 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8f88a850e01a8cc6706ac39f4f5dfa87f6f376b3
Cr-Commit-Position: refs/heads/master@{#345827}

Powered by Google App Engine
This is Rietveld 408576698