Issue 1315573004: bluetooth: Refactor code that checks if device/service/characteristic is in cache

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1315573004: bluetooth: Refactor code that checks if device/service/characteristic is in cache (Closed)

Created:
5 years, 3 months ago by ortuno

Modified:
5 years, 2 months ago

Reviewers:

CC:
chromium-reviews, darin-cc_chromium.org, scheib+watch_chromium.org, jam

Base URL:
https://chromium.googlesource.com/chromium/src.git@bluetooth-origin

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

bluetooth: Refactor code that checks if device/service/characteristic is in cache The code to check if device/service/characteristic is in cache is currently used by many functions and will be used by startNotification and stopNotification. To stop repeating the code we refactored it. I believe the code could be further simplified by using a more generic call to record function outcomes. But for now this would make the implementation of startNotification and stopNotification easier. BUG=529560

Patch Set 1 #

Created: 5 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+187 lines, -118 lines)			Patch
	M	content/browser/bluetooth/bluetooth_dispatcher_host.h	View		2 chunks	+21 lines, -0 lines	0 comments	Download
	M	content/browser/bluetooth/bluetooth_dispatcher_host.cc	View		6 chunks	+166 lines, -118 lines	0 comments	Download