DescriptionRevert of OOPIF: Call setCoreFrame on remote-to-local swaps. (patchset #4 id:60001 of https://codereview.chromium.org/1316863009/ )
Reason for revert:
I suspect this change broke webkit_unit_tests on Nexus 4:
All/ParameterizedWebFrameTest.RemoteToLocalSwapOnMainFrameInitializesCoreFrame/0
All/ParameterizedWebFrameTest.RemoteToLocalSwapOnMainFrameInitializesCoreFrame/1
All/WebFrameResizeTest.ResizeYieldsCorrectScrollAndScaleForFixedWidth/0
All/WebFrameResizeTest.ResizeYieldsCorrectScrollAndScaleForFixedWidth/1
All/WebFrameResizeTest.ResizeYieldsCorrectScrollAndScaleForMinimumScale/0
All/WebFrameResizeTest.ResizeYieldsCorrectScrollAndScaleForWidthEqualsDeviceWidth/1
All/WebFrameResizeTest.ResizeYieldsCorrectScrollAndScaleForFixedLayout/1
First failing build:
https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Android%20%28Nexus4%29/builds/37423
Blamelist:
http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=201725:201728&mode=html
http://test-results.appspot.com/revision_range?start=347178&end=347178
Original issue's description:
> OOPIF: Call setCoreFrame on remote-to-local swaps.
>
> This ensures that various initializion in setCoreFrame is triggered when
> doing remote-to-local swaps.
>
> BUG=525285
>
> Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201726
TBR=dcheng@chromium.org,alexmos@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=525285
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201756
Patch Set 1 #
Messages
Total messages: 6 (0 generated)
|