Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Issue 1315543009: Revert of OOPIF: Call setCoreFrame on remote-to-local swaps. (Closed)

Created:
5 years, 3 months ago by falken
Modified:
5 years, 3 months ago
Reviewers:
alexmos, dcheng
CC:
blink-reviews, site-isolation-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Revert of OOPIF: Call setCoreFrame on remote-to-local swaps. (patchset #4 id:60001 of https://codereview.chromium.org/1316863009/ ) Reason for revert: I suspect this change broke webkit_unit_tests on Nexus 4: All/ParameterizedWebFrameTest.RemoteToLocalSwapOnMainFrameInitializesCoreFrame/0 All/ParameterizedWebFrameTest.RemoteToLocalSwapOnMainFrameInitializesCoreFrame/1 All/WebFrameResizeTest.ResizeYieldsCorrectScrollAndScaleForFixedWidth/0 All/WebFrameResizeTest.ResizeYieldsCorrectScrollAndScaleForFixedWidth/1 All/WebFrameResizeTest.ResizeYieldsCorrectScrollAndScaleForMinimumScale/0 All/WebFrameResizeTest.ResizeYieldsCorrectScrollAndScaleForWidthEqualsDeviceWidth/1 All/WebFrameResizeTest.ResizeYieldsCorrectScrollAndScaleForFixedLayout/1 First failing build: https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Android%20%28Nexus4%29/builds/37423 Blamelist: http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=201725:201728&mode=html http://test-results.appspot.com/revision_range?start=347178&end=347178 Original issue's description: > OOPIF: Call setCoreFrame on remote-to-local swaps. > > This ensures that various initializion in setCoreFrame is triggered when > doing remote-to-local swaps. > > BUG=525285 > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201726 TBR=dcheng@chromium.org,alexmos@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=525285 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201756

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -35 lines) Patch
M Source/web/WebLocalFrameImpl.cpp View 2 chunks +7 lines, -9 lines 0 comments Download
M Source/web/tests/WebFrameTest.cpp View 1 chunk +0 lines, -26 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
falken
Created Revert of OOPIF: Call setCoreFrame on remote-to-local swaps.
5 years, 3 months ago (2015-09-04 01:33:32 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1315543009/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1315543009/1
5 years, 3 months ago (2015-09-04 01:33:45 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://src.chromium.org/viewvc/blink?view=rev&revision=201756
5 years, 3 months ago (2015-09-04 01:34:08 UTC) #3
dcheng
The Android build went green one build before this revert: https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Android%20%28Nexus4%29/builds/37425. Can we reland this ...
5 years, 3 months ago (2015-09-04 07:01:16 UTC) #4
falken
Wow, you're right. Do you have an idea how it healed? I'm afraid if I ...
5 years, 3 months ago (2015-09-04 07:47:31 UTC) #5
falken
5 years, 3 months ago (2015-09-04 07:48:11 UTC) #6
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1304093005/ by falken@chromium.org.

The reason for reverting is: Reland: The Android build went green one build
before this revert..

Powered by Google App Engine
This is Rietveld 408576698