Source/core/editing/FrameSelection.cpp - Issue 1315543002: Introduce createRange(const EphemeralRange&)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/editing/FrameSelection.cpp

Issue 1315543002: Introduce createRange(const EphemeralRange&) (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/editing/FrameSelection.cpp

diff --git a/Source/core/editing/FrameSelection.cpp b/Source/core/editing/FrameSelection.cpp

index 82ae876d13d18b0be5bc50271a87544d0226461f..49f173037c831154ae57d0904242cc8f76efa3e8 100644

--- a/Source/core/editing/FrameSelection.cpp

+++ b/Source/core/editing/FrameSelection.cpp

@@ -1488,7 +1488,7 @@ bool FrameSelection::setSelectedRange(const EphemeralRange& range, TextAffinity

// Since |FrameSeleciton::setSelection()| dispatches events and DOM tree

// can be modified by event handlers, we should create |Range| object before

// calling it.

- m_logicalRange = Range::create(range.document(), range.startPosition(), range.endPosition());

+ m_logicalRange = createRange(range);

VisibleSelection newSelection(range.startPosition(), range.endPosition(), affinity, directional == Directional);

setSelection(newSelection, options);