Move Android TraceEvent interface to base

Move Android TraceEvent interface to base

The platform independent C++ code for TraceEvent has always been in base.
This CL moves the Android specific code into base to match.

This CL is needed now since trace is used by the Android library loader,
which is moving out of content.

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=244153

[aberent, 2014-01-09 14:06:24]

piman@chromium.org: Please review changes in content_common.gypi (OWNER review)

ajwong@chromium.org: Please review changes in base.gyp and base.gypi (OWNER
review)

bulach@chromium.org: Please review entire CL. Note that the only change to most
of the Java files is a change to the TraceEvent import statement. The exceptions
are TraceEvent.java, PerfTraceEvent.java and VSyncMonitor.java.

[aberent, 2014-01-09 14:10:04]

https://codereview.chromium.org/131553003/diff/1/content/public/android/java/...
File
content/public/android/java/src/org/chromium/content/browser/VSyncMonitor.java
(right):

https://codereview.chromium.org/131553003/diff/1/content/public/android/java/...
content/public/android/java/src/org/chromium/content/browser/VSyncMonitor.java:30:
* VSync listener class
Added to pass (new?) pre-submit checks.

[aberent, 2014-01-09 14:15:57]

On 2014/01/09 14:10:04, aberent wrote:
>
https://codereview.chromium.org/131553003/diff/1/content/public/android/java/...
> File
> content/public/android/java/src/org/chromium/content/browser/VSyncMonitor.java
> (right):
> 
>
https://codereview.chromium.org/131553003/diff/1/content/public/android/java/...
>
content/public/android/java/src/org/chromium/content/browser/VSyncMonitor.java:30:
> * VSync listener class
> Added to pass (new?) pre-submit checks.

@bulach - re non-trivial changes. I also moved one constant from
ContentSwitches.java to BaseSwitches.java.

[bulach, 2014-01-09 14:54:50]

lgtm % one nit and one suggestion to make it easier to roll. thanks!

https://codereview.chromium.org/131553003/diff/1/base/android/trace_event_bin...
File base/android/trace_event_binding.h (right):

https://codereview.chromium.org/131553003/diff/1/base/android/trace_event_bin...
base/android/trace_event_binding.h:8: #include <jni.h>
nit: add a \n after the include

https://codereview.chromium.org/131553003/diff/1/content/public/android/java/...
File
content/public/android/java/src/org/chromium/content/common/PerfTraceEvent.java
(left):

https://codereview.chromium.org/131553003/diff/1/content/public/android/java/...
content/public/android/java/src/org/chromium/content/common/PerfTraceEvent.java:1:
// Copyright 2012 The Chromium Authors. All rights reserved.
see below, I think it'd be simpler to keep the public interface for a bit rather
than deleting it all at once..

https://codereview.chromium.org/131553003/diff/1/content/public/android/java/...
File content/public/android/java/src/org/chromium/content/common/TraceEvent.java
(left):

https://codereview.chromium.org/131553003/diff/1/content/public/android/java/...
content/public/android/java/src/org/chromium/content/common/TraceEvent.java:1:
// Copyright 2012 The Chromium Authors. All rights reserved.
deleting this file would break downstream.
two options:
1. have the downstream patch ready and notify the sheriff (less preferrable)
2. since all public methods are static, just keep them here and delegate them to
the new file in base... the downstream patch won't be necessary for the gardener
to keep rolling, and then later on remove this file..

[aberent, 2014-01-09 17:35:28]

https://codereview.chromium.org/131553003/diff/1/base/android/trace_event_bin...
File base/android/trace_event_binding.h (right):

https://codereview.chromium.org/131553003/diff/1/base/android/trace_event_bin...
base/android/trace_event_binding.h:8: #include <jni.h>
On 2014/01/09 14:54:50, bulach wrote:
> nit: add a \n after the include

Done.

https://codereview.chromium.org/131553003/diff/1/content/public/android/java/...
File
content/public/android/java/src/org/chromium/content/common/PerfTraceEvent.java
(left):

https://codereview.chromium.org/131553003/diff/1/content/public/android/java/...
content/public/android/java/src/org/chromium/content/common/PerfTraceEvent.java:1:
// Copyright 2012 The Chromium Authors. All rights reserved.
On 2014/01/09 14:54:50, bulach wrote:
> see below, I think it'd be simpler to keep the public interface for a bit
rather
> than deleting it all at once..

Done.

https://codereview.chromium.org/131553003/diff/1/content/public/android/java/...
File content/public/android/java/src/org/chromium/content/common/TraceEvent.java
(left):

https://codereview.chromium.org/131553003/diff/1/content/public/android/java/...
content/public/android/java/src/org/chromium/content/common/TraceEvent.java:1:
// Copyright 2012 The Chromium Authors. All rights reserved.
On 2014/01/09 14:54:50, bulach wrote:
> deleting this file would break downstream.
> two options:
> 1. have the downstream patch ready and notify the sheriff (less preferrable)
> 2. since all public methods are static, just keep them here and delegate them
to
> the new file in base... the downstream patch won't be necessary for the
gardener
> to keep rolling, and then later on remove this file..

Done. Option 2 (although the downstream patch is also ready).

[piman, 2014-01-09 18:17:26]

lgtm

[awong, 2014-01-09 20:59:24]

https://codereview.chromium.org/131553003/diff/90001/base/base.gyp
File base/base.gyp (right):

https://codereview.chromium.org/131553003/diff/90001/base/base.gyp#newcode1203
base/base.gyp:1203: 'android/java/src/org/chromium/base/TraceEvent.java',
Should there be a PerfTraceEvent.java somewhere in here?

[aberent, 2014-01-09 21:30:53]

https://codereview.chromium.org/131553003/diff/90001/base/base.gyp
File base/base.gyp (right):

https://codereview.chromium.org/131553003/diff/90001/base/base.gyp#newcode1203
base/base.gyp:1203: 'android/java/src/org/chromium/base/TraceEvent.java',
On 2014/01/09 20:59:24, awong wrote:
> Should there be a PerfTraceEvent.java somewhere in here?

No, this only lists Java files that call native functions, and hence generate
jni interfaces. PerfTraceEvent.java doesn't call any native functions.

[awong, 2014-01-09 21:32:52]

On 2014/01/09 21:30:53, aberent wrote:
> https://codereview.chromium.org/131553003/diff/90001/base/base.gyp
> File base/base.gyp (right):
> 
> https://codereview.chromium.org/131553003/diff/90001/base/base.gyp#newcode1203
> base/base.gyp:1203: 'android/java/src/org/chromium/base/TraceEvent.java',
> On 2014/01/09 20:59:24, awong wrote:
> > Should there be a PerfTraceEvent.java somewhere in here?
> 
> No, this only lists Java files that call native functions, and hence generate
> jni interfaces. PerfTraceEvent.java doesn't call any native functions.

base gyp/gypi LGTM

[commit-bot: I haz the power, 2014-01-10 09:55:29]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/aberent@chromium.org/131553003/90001

[commit-bot: I haz the power, 2014-01-10 12:38:12]

Change committed as 244153